Skip to content

PHPLIB-1656: Stop testing with MongoDB 4.0 #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented May 20, 2025

PHPLIB-1656

Support for MongoDB 4.0 will be dropped in a future extension release, but we can stop testing with MongoDB 4.0 already.

@alcaeus alcaeus requested a review from a team as a code owner May 20, 2025 07:37
@alcaeus alcaeus requested a review from GromNaN May 20, 2025 07:37
@alcaeus alcaeus force-pushed the phplib-1656-drop-server-4.0 branch from 1ee02a2 to 8947874 Compare May 20, 2025 07:43
@GromNaN GromNaN changed the title PHPLIB-1656: Stop testing with MongoDB 4.0 PHPLIB-1656: Drop support for MongoDB 4.0 May 20, 2025
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the PR as you dropped a specific error handling for MongoDB 4.0 in the aggregate operation.

Cleanup/refactor any code that isn't needed anymore (code needed to support server version 4.0)

@alcaeus
Copy link
Member Author

alcaeus commented May 20, 2025

Good point - with that in mind we may want to wait until connecting to a 4.0 server is rejected by libmongoc. I'll move this into draft until such time.

@alcaeus alcaeus marked this pull request as draft May 20, 2025 07:56
@alcaeus alcaeus force-pushed the phplib-1656-drop-server-4.0 branch from 8947874 to 726cba9 Compare May 20, 2025 12:46
@alcaeus alcaeus changed the title PHPLIB-1656: Drop support for MongoDB 4.0 PHPLIB-1656: Stop testing with MongoDB 4.0 May 20, 2025
@alcaeus alcaeus marked this pull request as ready for review May 20, 2025 12:47
@alcaeus alcaeus requested a review from GromNaN May 20, 2025 12:47
@alcaeus
Copy link
Member Author

alcaeus commented May 20, 2025

@GromNaN dropped the last commit, so this PR now only drops testing without making any changes to the operations themselves. These changes will be made after we upgrade to libmongoc 2.1 in the extension.

@alcaeus alcaeus enabled auto-merge (squash) May 20, 2025 13:01
@alcaeus alcaeus merged commit 8bcdf7a into mongodb:v2.x May 20, 2025
31 checks passed
@alcaeus alcaeus deleted the phplib-1656-drop-server-4.0 branch May 20, 2025 13:22
alcaeus added a commit that referenced this pull request Jun 4, 2025
* v2.1: (50 commits)
  Fix missing placeholder replacement in release output (#1717)
  Use more lax assertion when checking exception message (#1712)
  Test against stable 2.1 version of the extension (#1698)
  Use assume_role command before accessing secrets for atlas-data-lake tests
  PHPLIB-1656: Stop testing with MongoDB 4.0 (#1693)
  Make serverless tasks patch-only (#1692)
  Bump tests/specifications from `cea6c7d` to `9d0d3f0` (#1690)
  Bump tests/drivers-evergreen-tools from `21b4109` to `32fd8eb` (#1691)
  PHPLIB-847, PHPLIB-1627: BulkWriteCommand API (#1630)
  Bump tests/specifications from `0c41c8b` to `cea6c7d` (#1688)
  Bump tests/drivers-evergreen-tools from `fa58b39` to `21b4109` (#1689)
  Test next next minor PHP version with PHP 8.4 (#1685)
  Bump tests/drivers-evergreen-tools from `9be5587` to `fa58b39` (#1679)
  Bump tests/specifications from `43d2c7b` to `0c41c8b` (#1680)
  Bump tests/drivers-evergreen-tools from `cec0139` to `9be5587` (#1676)
  Bump tests/drivers-evergreen-tools from `d1e19b1` to `cec0139` (#1675)
  Bump tests/specifications from `6118deb` to `43d2c7b` (#1674)
  Bump tests/drivers-evergreen-tools from `f53da28` to `d1e19b1` (#1673)
  Test against stable 2.0 version of the extension (#1663)
  Bump tests/specifications from `f354960` to `6118deb`
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants