chore: defer machine ID resolution #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
Apr 29, 2025
| private readonly eventCache: EventCache | ||
| ) {} | ||
|
|
||
| static create( |
There was a problem hiding this comment.
while this is not asyncronous. I'm using create(...) to make it clear there are associated side effects
gagik
force-pushed
the
gagik/use-machine-id
branch
3 times, most recently
from
f9ba638 to
2eb44fb
Compare
gagik
force-pushed
the
gagik/use-machine-id
branch
2 times, most recently
from
b78be48 to
9be3e12
Compare
gagik
force-pushed
the
gagik/use-machine-id
branch
3 times, most recently
from
5ae2584 to
5348a3a
Compare
gagik
force-pushed
the
gagik/use-machine-id
branch
from
af9631b to
c869d63
Compare
|
This has revealed a very major problem with our Build vs Jest setup targetting entirely different module resolutions... Unfortunately I can't think of a good solution... |
We did not have a full ESM configuration for jest and therefore had a discrepancy between our build vs test. This discrepancy leads to issues with CommonJS modules.
…rver into gagik/use-machine-id
…gagik/use-machine-id
gagik
commented
Apr 30, 2025
| @@ -76,8 +76,6 @@ export function setupMongoDBIntegrationTest(): MongoDBIntegrationTest { | |||
| let dbsDir = path.join(tmpDir, "mongodb-runner", "dbs"); | |||
| for (let i = 0; i < 10; i++) { | |||
| try { | |||
| // TODO: Fix this type once mongodb-runner is updated. | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call | |||
nirinchev
reviewed
Apr 30, 2025
Comment on lines
+8
to
+9
| resolve!: (value: T) => void; | ||
| reject!: (reason: unknown) => void; |
There was a problem hiding this comment.
Do we need the assertions here?
Suggested change
| resolve!: (value: T) => void; | |
| reject!: (reason: unknown) => void; | |
| resolve: (value: T) => void; | |
| reject: (reason: unknown) => void; |
There was a problem hiding this comment.
yeah, this is more of a late intialization assertion. typescript isn't smart enough to understand they're being set in the constructor
gagik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
This defers the device ID resolution and add a timeout for resolution. Buffers events in the meantime.