fix: improve api error messages #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the API error messaging in the atlas client by refining the error detail extraction and formatting.
- Introduces an additional parameter (body) to capture detailed API errors.
- Refactors the static error construction method to handle both JSON and text responses gracefully.
Co-authored-by: Copilot <[email protected]>
blva
reviewed
Apr 30, 2025
src/common/atlas/apiClientError.ts
Outdated
| try { | ||
| text = await response.text(); | ||
| } catch { | ||
| text = ""; |
There was a problem hiding this comment.
should we set to something like "couldn't fetch error" or "unknown error" too
blva
approved these changes
Apr 30, 2025
gagik
reviewed
Apr 30, 2025
src/common/atlas/apiClientError.ts
Outdated
| private constructor( | ||
| message: string, | ||
| public readonly response?: Response, | ||
| public readonly body?: ApiError |
There was a problem hiding this comment.
is there a benefit to us storing the body?
There was a problem hiding this comment.
Getting the ApiError model gives us insight into backend error codes, some tools might require an if/else depending on the backend error code.
|
Looks good but I agree we should hold off from merging/releasing for the time being like with #161 as it's not super critical yet. |
|
@gagik I think this change fixes type errors from apiClient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.