Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Conversation

@mlafleur
Copy link

The Reports.Read.All scope is required for users to exploer the various
reports currently in the beta endpoint. This scope is currently in
preview and requires consent.

The Reports.Read.All scope is required for users to exploer the various
reports currently in the beta endpoint.  This scope is currently in
preview and requires consent.
@msftclas
Copy link

@mlafleur,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dan-silver
Copy link
Contributor

Thanks Marc! That's odd the build is failing on Node 7 but works on Node 8. I doubt it's related but want to take a look before merging.

@dan-silver dan-silver merged commit 093600e into microsoftgraph:master Jun 28, 2017
@mlafleur
Copy link
Author

Were you able to sort out why Travis was failing for 7 but not 8?

@dan-silver
Copy link
Contributor

That issue was fixed in #47. This project was configured to use TypeScript in 2.x and 2.4 was just released with stronger type checking that causes RxJS to not compile. We'll stick with 2.3 for now. For more info on their compile bug, see ReactiveX/rxjs#2540

@dan-silver
Copy link
Contributor

So this PR was merged in with #48 after applying the fix to use TS 2.3 and all the tests passed. Thanks again Marc!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants