Skip to content

fix blue color on export icon #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix blue color on export icon #8449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/8424.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Export to python button is blue in native editor.
9 changes: 0 additions & 9 deletions src/datascience-ui/native-editor/nativeEditor.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,15 +301,6 @@
color: var(--override-foreground, var(--vscode-editor-foreground));
}

.save-button {
background: var(--vscode-button-background);
color: var(--vscode-button-foreground);
padding: 2px;
border: none;
cursor: pointer;
margin:2px 4px;
}

.native-button {
margin-top: 3px;
}
Expand Down
2 changes: 1 addition & 1 deletion src/datascience-ui/native-editor/nativeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export class NativeEditor extends React.Component<INativeEditorProps, IMainState
<ImageButton baseTheme={this.state.baseTheme} onClick={this.saveFromToolbar} disabled={!this.state.dirty} className='native-button' tooltip={getLocString('DataScience.save', 'Save File')}>
<Image baseTheme={this.state.baseTheme} class='image-button-image' image={ImageName.SaveAs} />
</ImageButton>
<ImageButton baseTheme={this.state.baseTheme} onClick={this.stateController.export} disabled={!this.stateController.canExport()} className='save-button' tooltip={getLocString('DataScience.exportAsPythonFileTooltip', 'Save As Python File')}>
<ImageButton baseTheme={this.state.baseTheme} onClick={this.stateController.export} disabled={!this.stateController.canExport()} className='native-button' tooltip={getLocString('DataScience.exportAsPythonFileTooltip', 'Save As Python File')}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny, I think this issue always existed, but was just exposed by some recent changes to the css ordering.

<Image baseTheme={this.state.baseTheme} class='image-button-image' image={ImageName.ExportToPython} />
</ImageButton>
</div>
Expand Down