Ensure a refresh is only triggered after all handlers are registered in quickpicker #19579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
commented
Jul 27, 2022
| const stopWatch = new StopWatch(); | ||
| let refreshPromise = this.getRefreshPromiseForQuery(query); | ||
| if (!refreshPromise) { | ||
| if (options?.ifNotTriggerredAlready && this.hasRefreshFinished(query) && this.getEnvs().length) { |
There was a problem hiding this comment.
Causes an infinite loop #19574.
| // refresh button if they want to trigger it more than once. However if no envs were found previously, | ||
| // always trigger a refresh. | ||
| if (this.interpreterService.getInterpreters().length === 0) { | ||
| this.interpreterService.triggerRefresh().ignoreErrors(); |
There was a problem hiding this comment.
Instead the consumers themselves can implement this option.
paulacamargo25
approved these changes
Jul 28, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…in quickpicker (microsoft/vscode-python#19579) * Ensure a refresh is only triggered after all handlers are registered for the quickpick * Do not show install python item until we're sure no python is installed * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19562 closes #19576 closes #19574