Skip to content

Ensure we log experiments even when disabled #17922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Ensure we log experiments even when disabled #17922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/client/common/experiments/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,16 +143,19 @@ export class ExperimentService implements IExperimentService {

private logExperiments() {
const telemetrySettings = this.workspaceService.getConfiguration('telemetry');
let experimentsDisabled = false;
if (telemetrySettings && telemetrySettings.get<boolean>('enableTelemetry') === false) {
this.output.appendLine('Telemetry is disabled');
this.output.appendLine('Experiments are disabled');
return;
experimentsDisabled = true;
}

if (telemetrySettings && telemetrySettings.get<string>('telemetryLevel') === 'off') {
this.output.appendLine('Telemetry level is off');
this.output.appendLine('Experiments are disabled');
return;
experimentsDisabled = true;
}

if (experimentsDisabled) {
this.output.appendLine('Experiments are disabled, logging experiments for info.');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig Wait, doesn't this mean experiments from storage are still logged if telemetry is disabled? I think we should only log experiment from settings, but not log experiments from storage if telemetry is disabled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of the day, all we need to know is that experiments are disabled. Everything else is just for info. What is the benefit of skipping the stored details?

Copy link

@karrtikr karrtikr Nov 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually opted in/out experiments are still valid even though telemetry is disabled, so we should only be logging experiments from settings.

}

if (this._optOutFrom.includes('All')) {
Expand Down