Ensure we log experiments even when disabled #17922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
added
no-changelog
karrtikr
reviewed
Nov 5, 2021
| } | ||
|
|
||
| if (experimentsDisabled) { | ||
| this.output.appendLine('Experiments are disabled, logging experiments for info.'); |
There was a problem hiding this comment.
@karthiknadig Wait, doesn't this mean experiments from storage are still logged if telemetry is disabled? I think we should only log experiment from settings, but not log experiments from storage if telemetry is disabled.
There was a problem hiding this comment.
At the end of the day, all we need to know is that experiments are disabled. Everything else is just for info. What is the benefit of skipping the stored details?
There was a problem hiding this comment.
Manually opted in/out experiments are still valid even though telemetry is disabled, so we should only be logging experiments from settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17429