Skip to content

feat. Support version tag #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2023
Merged

feat. Support version tag #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
229fd2b
feat. support version tag p1
albertli-msft Mar 27, 2023
bb164d3
feat. support version tag p2: i18n strings
albertli-msft Mar 27, 2023
5e99cac
feat. support version tag p3: lint i18n strings
albertli-msft Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 56 additions & 21 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,74 +116,109 @@
"configuration": {
"title": "Power Query SDK",
"properties": {
"powerquery.sdk.features.autoDetection": {
"scope": "machine-overridable",
"type": "boolean",
"description": "%extension.pqtest.config.features.autoDetection.description%",
"default": true,
"order": 9
},
"powerquery.sdk.project.autoDetection": {
"scope": "machine-overridable",
"type": "boolean",
"description": "%extension.pqtest.config.features.autoDetection.description%",
"default": true,
"order": 10,
"deprecationMessage": "Deprecated: Please use powerquery.sdk.features.autoDetection instead.",
"markdownDeprecationMessage": "**Deprecated**: Please use `#powerquery.sdk.features.autoDetection#` instead."
},
"powerquery.sdk.pqtest.location": {
"powerquery.sdk.features.useServiceHost": {
"scope": "machine-overridable",
"type": "boolean",
"default": false,
"order": 10,
"description": "%extension.pqtest.config.features.useServiceHost%"
},
"powerquery.sdk.defaultExtension": {
"scope": "window",
"type": "string",
"deprecationMessage": "Deprecated: Please use powerquery.sdk.tools.location instead.",
"description": "%extension.pqtest.config.pqtest.location.description%"
"order": 29,
"description": "%extension.pqtest.config.pqtest.extension.description%"
},
"powerquery.sdk.defaultQueryFile": {
"scope": "window",
"type": "string",
"order": 29,
"description": "%extension.pqtest.config.pqtest.queryFile.description%"
},
"powerquery.sdk.pqtest.extension": {
"scope": "window",
"type": "string",
"order": 30,
"deprecationMessage": "Deprecated: Please use powerquery.sdk.defaultExtension instead.",
"description": "%extension.pqtest.config.pqtest.extension.description%"
},
"powerquery.sdk.pqtest.queryFile": {
"scope": "window",
"type": "string",
"order": 30,
"deprecationMessage": "Deprecated: Please use powerquery.sdk.defaultQueryFile instead.",
"description": "%extension.pqtest.config.pqtest.queryFile.description%"
},
"powerquery.sdk.externals.msbuildPath": {
"scope": "machine-overridable",
"type": "string",
"order": 50,
"description": "%extension.pqtest.config.externals.msbuildPath.description%"
},
"powerquery.sdk.externals.nugetPath": {
"scope": "machine-overridable",
"type": "string",
"order": 50,
"description": "%extension.pqtest.config.externals.nugetPath.description%"
},
"powerquery.sdk.externals.versionTag": {
"scope": "machine-overridable",
"type": "string",
"enum": [
"Recommended",
"Latest",
"Custom"
],
"enumDescriptions": [
"%extension.pqtest.config.externals.versionTag.recommended.description%",
"%extension.pqtest.config.externals.versionTag.latest.description%",
"%extension.pqtest.config.externals.versionTag.customized.description%"
],
"description": "%extension.pqtest.config.externals.versionTag.description%",
"default": "Recommended",
"order": 50
},
"powerquery.sdk.externals.nugetFeed": {
"scope": "window",
"type": "string",
"order": 50,
"description": "%extension.pqtest.config.externals.nugetFeed.description%",
"default": ""
},
"powerquery.sdk.tools.location": {
"scope": "machine-overridable",
"type": "string",
"order": 69,
"description": "%extension.pqtest.config.pqtest.location.description%"
},
"powerquery.sdk.defaultExtension": {
"scope": "window",
"type": "string",
"description": "%extension.pqtest.config.pqtest.extension.description%"
},
"powerquery.sdk.defaultQueryFile": {
"scope": "window",
"type": "string",
"description": "%extension.pqtest.config.pqtest.queryFile.description%"
},
"powerquery.sdk.features.autoDetection": {
"powerquery.sdk.pqtest.location": {
"scope": "machine-overridable",
"type": "boolean",
"description": "%extension.pqtest.config.features.autoDetection.description%",
"default": true
"type": "string",
"order": 70,
"deprecationMessage": "Deprecated: Please use powerquery.sdk.tools.location instead.",
"description": "%extension.pqtest.config.pqtest.location.description%"
},
"powerquery.sdk.features.useServiceHost": {
"powerquery.sdk.tools.version": {
"scope": "machine-overridable",
"type": "boolean",
"default": false,
"description": "%extension.pqtest.config.features.useServiceHost%"
"type": "string",
"order": 71,
"description": "%extension.pqtest.config.pqtest.version.description%"
}
}
},
Expand Down
5 changes: 5 additions & 0 deletions package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,14 @@
"extension.pqtest.config.externals.msbuildPath.description": "Local path to msbuild.exe installation folder.",
"extension.pqtest.config.externals.nugetPath.description": "Local path to nuget.exe installation folder.",
"extension.pqtest.config.externals.nugetFeed.description": "Suggested nuget feed URL.",
"extension.pqtest.config.externals.versionTag.description": "The version tag of the PQ SDK tools to be downloaded.",
"extension.pqtest.config.externals.versionTag.recommended.description": "The stable version",
"extension.pqtest.config.externals.versionTag.latest.description": "The latest version",
"extension.pqtest.config.externals.versionTag.customized.description": "Use a user provided version value",
"extension.pqtest.config.features.autoDetection.description": "When set to false, the SDK does not try to automatically detect connector workspaces and prompt to create a settings file.",
"extension.pqtest.config.features.useServiceHost": "Try the new feature using a reusable engine service host other than the command lines",
"extension.pqtest.config.pqtest.location.description": "Local path to PQTest installation folder.",
"extension.pqtest.config.pqtest.version.description": "The local PQ SDK tools version.",
"extension.pqtest.config.pqtest.extension.description": "Specify connector extension source modules (.mez/.pqm).<br>This option can be specified more than once.",
"extension.pqtest.config.pqtest.queryFile.description": "Query file containing section document or M expression (.m/.pq).",
"extension.pqtest.taskDefinitions.properties.operation.description": "The operation to run",
Expand Down
14 changes: 14 additions & 0 deletions src/GlobalEventBus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ export const GlobalEvents = Object.freeze({
ConfigDidChangePowerQueryTestLocation: "ConfigDidChangePowerQueryTestLocation" as const,
ConfigDidChangePQTestExtension: "ConfigDidChangePQTestExtension" as const,
ConfigDidChangePQTestQuery: "ConfigDidChangePQTestQuery" as const,
ConfigDidChangeExternalVersionTag: "ConfigDidChangeExternalVersionTag" as const,
ConfigDidChangePqTestVersion: "ConfigDidChangePqTestVersion" as const,
}),
});
type GlobalEventTypes = ExtractEventTypes<typeof GlobalEvents>;
Expand Down Expand Up @@ -122,6 +124,18 @@ export class GlobalEventBus extends DisposableEventEmitter<GlobalEventTypes> imp
void vscode.commands.executeCommand("workbench.action.reloadWindow");
}
})();
} else if (
evt.affectsConfiguration(
`${ExtensionConstants.ConfigNames.PowerQuerySdk.name}.${ExtensionConstants.ConfigNames.PowerQuerySdk.properties.externalsVersionTag}`,
)
) {
this.emit(GlobalEvents.VSCodeEvents.ConfigDidChangeExternalVersionTag);
} else if (
evt.affectsConfiguration(
`${ExtensionConstants.ConfigNames.PowerQuerySdk.name}.${ExtensionConstants.ConfigNames.PowerQuerySdk.properties.pqTestVersion}`,
)
) {
this.emit(GlobalEvents.VSCodeEvents.ConfigDidChangePqTestVersion);
}
} else if (evt.affectsConfiguration(ExtensionConstants.ConfigNames.PowerQuery.name)) {
if (
Expand Down
Loading