Skip to content

feat. Support version tag #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2023
Merged

feat. Support version tag #259

merged 3 commits into from
Mar 28, 2023

Conversation

@albertli-msft
Copy link
Contributor

@albertli-msft albertli-msft commented Mar 27, 2023 •
edited
Loading

  • chore. sort config setting items a little bit
  • support version tags allowing users to choose from Recommended/Latest/Customized sdkTools
  • create doUpdatePqTestLocationAndStartItIfNeeded to remove few duplicated codes in LifecycleCommands
  • NugetVersion util method and its unit test cases
pr_259_Code_ovhX23o62c.mp4

mattmasson
mattmasson requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@mattmasson mattmasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor string changes only

@albertli-msft albertli-msft merged commit f026ea8 into main Mar 28, 2023
@albertli-msft albertli-msft deleted the dev/albertli/support-version-tag branch March 28, 2023 13:24
@mattmasson mattmasson mentioned this pull request Jan 26, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmasson mattmasson mattmasson approved these changes

@JordanBoltonMN JordanBoltonMN Awaiting requested review from JordanBoltonMN

@ptyx507x ptyx507x Awaiting requested review from ptyx507x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albertli-msft @mattmasson