This repository was archived by the owner on Nov 30, 2023. It is now read-only.
Remove pre-set terminal setting once 1.57 is released #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
May 13, 2021
| @@ -9,9 +9,7 @@ | |||
| }, | |||
|
|
|||
| // Set *default* container specific settings.json values on container create. | |||
| "settings": { | |||
| "terminal.integrated.shell.linux": null | |||
There was a problem hiding this comment.
What was this meant to accomplish? Overriding the user setting in case it's not installed?
There was a problem hiding this comment.
Correct. The fallback eliminates the need for it.
@Tyriar Yep - this gives us an easy PR to test them. Given 1.56 just came out, we can hold a bit before merging. I did see this working in VS Code Insiders 1.57, but 1.56.1 didn't seem to pick up updated the setting when I tried it. (Its set in the PowerShell definition since the point of that one is to use powershell. 😄 ) So I assume it and the fallback aren't there yet. |
…ners into clantz/change-terminal-setting
|
Merging in prep for 1.57 endgame week. FYI @chrmarti |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
"terminal.integrated.shell.linux"setting that was in place due to the fact that shells likezshare often not in containers. Previously in this scenario, a user setting would cause the terminal not to appear.The new terminal "profile" capability in VS Code solves this by falling back to either
$SHELLor the shell in/etc/passwdif the specified profile fails as of the upcoming VS Coe 1.57 release (currently in insiders).Related: microsoft/vscode#123157, #838