vscode remote container Haskell #685
Conversation
|
|
There was a problem hiding this comment.
Made a few suggestions. The other is that this definition needs a README.md file. There's a metadata section in particular that is used by the product for detection.
The template is here: https://github.com/microsoft/vscode-dev-containers/blob/main/container-templates/dockerfile/README.md
Listing 9, 8 Co-authored-by: Chuck Lantz <[email protected]>
Remove TODO template information demonstration where to add additional OS packages. Co-authored-by: Chuck Lantz <[email protected]>
Reflect community created. Co-authored-by: Chuck Lantz <[email protected]>
Removed commented code demonstrating how to use Docker inside container and ptrace-based debugger. Co-authored-by: Chuck Lantz <[email protected]>
Add README to definition
As requested I've added a README.md to the definition. Let me know if it's suitable. |
|
Hi, Common-debian.sh may need to be updated. |
|
|
||
| // Set *default* container specific settings.json values on container create. | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" |
There was a problem hiding this comment.
This setting is now deprecated and has been removed from other container definitions in #860.
Use updated common-debian.sh file
I've updated as suggested. |
Add contributor
Added contributors
Show where to set Haskell version utilizing choice option. Co-authored-by: Chuck Lantz <[email protected]>
Add build.args property
|
LGTM! |
|
@stuartpike thanks again for prepraing the pr and thanks to @Chuxel for moving it forward |
|
@Chuxel dont want to bother you too much but would be any chance to add a |
Files needed to create vscode remote container for Haskell