Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Conversation

midnightexigent
Copy link

  • use rust-analyzer for better linting and auto-complete
  • add crates extension for better experience when editing Cargo.toml
  • use Even Better TOML for an even better experience when editing Cargo.toml

@ghost
Copy link

ghost commented Feb 18, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing and there may have some advice, please kindly take a look.

@2percentsilk
Copy link
Member

Hey there!
Even Better TOML is a relatively recent extension that doesn't have a high level of usage yet. How necessary do you think it is?
If we could leave it out for now, we're happy to add the other two extensions to the definition.

@midnightexigent
Copy link
Author

midnightexigent commented Apr 14, 2021

Hello

How necessary do you think it is?

At the time I made the PR, Even better TOML was the only TOML extension that had autocomplete for Cargo.toml files. Meaning that it was the only extension that had schema support. Other extensions didn't seem to do much other that syntax highlight (I could be wrong about the last part)

@zebp
Copy link

zebp commented Jun 7, 2021

Giving this a bump, switching from RLS to rust-analyzer would make using the official devcontainer a smoother experience.

@Chuxel Chuxel requested a review from 2percentsilk June 24, 2021 23:18
@Aisuko
Copy link
Contributor

Aisuko commented Jun 29, 2021

hi @midnightexigent , I guess there may need a git rebase, let's do this? I believe this is the final step that the PR get merge.

@midnightexigent
Copy link
Author

@Aisuko

Done

@Aisuko
Copy link
Contributor

Aisuko commented Jul 4, 2021

Hi, @midnightexigent Thanks a lot.

@Aisuko
Copy link
Contributor

Aisuko commented Jul 4, 2021

Hi @2percentsilk, Would you please help to merge this?

@midnightexigent
Copy link
Author

I marked the changes as resolved, is that sufficient ?

@2percentsilk 2percentsilk merged commit 9a8be04 into microsoft:main Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants