Aded manpages (posix, posix-dev, dev) to common-debian.sh

[samruddhikhandale]

Fixes: Add manpages, manpages-posix to C++ and kitchen sink, possibly other images

Added following packages to common-debian.sh

• manpages-dev
• manpages-posix
• manpages-posix-dev

[Chuxel]

Generally looks right, but there's a few key things here since this script can be run for Ubuntu and Debian... this is one case where there's some subtle differences that are important.

[Chuxel]

I got pulled into meetings but I hit a couple of issues when trying the "debian" definition. I'll type up more on how I think we can resolve it with sed in a bit. (EDIT: I've since added the sed idea in the related inline comment.)

BTW - A simple way to copy scripts to everything is to run the following from the vscode-dev-containers repo.

yarn install
build/vscdc copy-library-scripts

This is what CI does and will copy whatever is in the script-library folder to all definitions that use the script. You can then just open containers/debian or containers/ubuntu in Remote - Containers to test.

[Chuxel]

@samruddhikhandale This looks good!

Last nit: I think we can drop the arguments for the definitions for the Oh My and the free packages flags. That would show up in the VS Code "Add Dev Container Config" UX which is going to confuse the average developer.

The main place I want to be sensitive to is those using the script for their own images given there will be some that want to stick with Debian "free" packages only.

We can just do /bin/bash /tmp/library-scripts/common-debian.sh "${INSTALL_ZSH}" "${USERNAME}" "${USER_UID}" "${USER_GID}" "${UPGRADE_PACKAGES}" true true in ours.

[samruddhikhandale]

@samruddhikhandale This looks good!

Last nit: I think we can drop the arguments for the definitions for the Oh My and the free packages flags. That would show up in the VS Code "Add Dev Container Config" UX which is going to confuse the average developer.

The main place I want to be sensitive to is those using the script for their own images given there will be some that want to stick with Debian "free" packages only.

We can just do /bin/bash /tmp/library-scripts/common-debian.sh "${INSTALL_ZSH}" "${USERNAME}" "${USER_UID}" "${USER_GID}" "${UPGRADE_PACKAGES}" true true in ours.

I see. Made the changes.

[samruddhikhandale]

Closed previously by mistake :)

[Chuxel]

LGTM! Merging