Skip to content

Skip a flaky matmul test | test(atenlib) #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Skip a flaky matmul test | test(atenlib) #586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e952d
Skip a flaky matmul test | test(atenlib)
justinchuby Apr 3, 2023
2027431
Update ops_correctness_test.py
justinchuby Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,11 @@ def _where_input_wrangler(
matcher=lambda sample: not (sample.args[0][0].dtype == torch.bool),
reason="this Aten overload only support tensor(bool) as args",
),
skip(
"matmul",
matcher=lambda sample: torch.numel(sample.input) == 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is relationship of sample.input and sample.args btw?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input is the first input. args[...] starts from the second

reason="values of matmul of [m, 0] and [0, n] matrices are undefined",
),
skip(
"min", # aten_mean
matcher=lambda sample: len(sample.args) > 0,
Expand Down