Skip a flaky matmul test | test(atenlib) #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BowenBao Inputs are actually printed here I just didn't realize it was special |
BowenBao
approved these changes
Apr 3, 2023
BowenBao
reviewed
Apr 3, 2023
| @@ -821,6 +821,11 @@ def _where_input_wrangler( | |||
| matcher=lambda sample: not (sample.args[0][0].dtype == torch.bool), | |||
| reason="this Aten overload only support tensor(bool) as args", | |||
| ), | |||
| skip( | |||
| "matmul", | |||
| matcher=lambda sample: torch.numel(sample.input) == 0, | |||
There was a problem hiding this comment.
what is relationship of sample.input and sample.args btw?
There was a problem hiding this comment.
input is the first input. args[...] starts from the second
|
You have successfully added a new lintrunner configuration |
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 74.13% 74.13%
=======================================
Files 109 109
Lines 11157 11157
Branches 1147 1147
=======================================
Hits 8271 8271
Misses 2575 2575
Partials 311 311
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 26, 2024
Fixes #117718 Fixes #117725 It's actually a known issue in microsoft/onnxscript#586, and we do exclude the empty input test cases in aten_matmul. This PR follows the skip, and add aten_mm as well. Pull Request resolved: #118413 Approved by: https://github.com/thiagocrepaldi
jeffdaily
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Feb 8, 2024
Fixes pytorch#117718 Fixes pytorch#117725 It's actually a known issue in microsoft/onnxscript#586, and we do exclude the empty input test cases in aten_matmul. This PR follows the skip, and add aten_mm as well. Pull Request resolved: pytorch#118413 Approved by: https://github.com/thiagocrepaldi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORT matmul produces nan on inputs with zero elements nondeterministically.
Fixes #538