-
Notifications
You must be signed in to change notification settings - Fork 64
Formally drop python 3.8 support #2234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ 35 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR formally drops Python 3.8 support by updating type annotations to use built‐in generic types and related modern idioms. Key changes include:
- Replacing Legacy typing generics (e.g. Tuple, List, Dict) with built‐in alternatives (e.g. tuple, list, dict) and updated imports from collections.abc.
- Consistent conversion of type hints across multiple files in the codebase to align with Python 3.9+ standards.
Reviewed Changes
Copilot reviewed 79 out of 79 changed files in this pull request and generated no comments.
File | Description |
---|---|
onnxscript/function_libs/torch_lib/ops/core.py | Updated type hint return types from Tuple[...] to tuple[...] |
onnxscript/function_libs/torch_lib/graph_building/_graph_building_torch.py | Converted multiple type hints (Tuple, Dict, List) to built‐in generics and adjusted import sources |
onnxscript/function_libs/tools/torch_lib/*.py | Changed usage of legacy typing generics to their built‐in versions (e.g. list, dict, etc.) |
onnxscript/_internal/*.py and others | Updated type annotations and related imports to reflect modern Python syntax |
Python 3.8 has reached EOL.
Fix #2233