-
Notifications
You must be signed in to change notification settings - Fork 80
Closed
Description
Hi,
I've noticed that the codebase currently mixes built-in generics (e.g., list
, set
, dict
) with typing module equivalents (e.g., List
, Set
, Dict
) in type hints. This leads to runtime errors when using Python 3.8, where native generics like set[Tuple[str, Optional[int]]]
are not yet supported.
onnxscript/onnxscript/ir/_tape.py
Line 19 in 2ae13be
UsedOpsets = set[Tuple[str, Optional[int]]] |
SymbolicValue = Union[ir.Value, list[ir.Value], ir.Shape] |
Is there any plan to:
- Drop support for Python 3.8, or
- Update type hints to consistently use typing generics for compatibility?
Metadata
Metadata
Assignees
Labels
No labels