Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Alert component follow-up #1077

Closed
5 tasks
bmdalex opened this issue Mar 19, 2019 · 1 comment
Closed
5 tasks

Alert component follow-up #1077

bmdalex opened this issue Mar 19, 2019 · 1 comment
Assignees
Labels
⚙️ enhancement New feature or request vsts Paired with ticket in vsts

Comments

@bmdalex
Copy link
Collaborator

bmdalex commented Mar 19, 2019

Alert component follow-up

Alert component was created in #1063 there are a few things we need to follow up on:

interface AlertPropsV2 extends AlertProps {
  /** The title of the alert **/
  header?: string

  /** An alert may be formatted to display an error or negative message. */
  error?: boolean
  negative?: boolean // EXPERIMENTAL - not sure we will add both

  /** An alert may be formatted to display a positive message. */
  positive?: boolean // EXPERIMENTAL - synonym for success  not sure we will add it
  
  /** Defines whether Alert is displayed. */
  open?: boolean

  /** Event for request to change 'open' value. */
  onOpenChange?: ComponentEventHandler<PopupProps>

  /** EXPERIMENTAL - some Alerts might need different style for all types/intents */
  appearance?: 'basic' | 'card'
}
@bmdalex bmdalex added the ⚙️ enhancement New feature or request label Mar 19, 2019
@bmdalex bmdalex self-assigned this Mar 19, 2019
@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Mar 19, 2019
@jurokapsiar
Copy link
Contributor

this is not required anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ enhancement New feature or request vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

3 participants