This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(alert): v1 #1063
Merged
feat(alert): v1 #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1063 +/- ##
=========================================
- Coverage 81.91% 81.8% -0.11%
=========================================
Files 693 696 +3
Lines 8450 8499 +49
Branches 1233 1168 -65
=========================================
+ Hits 6922 6953 +31
- Misses 1513 1531 +18
Partials 15 15
Continue to review full report at Codecov.
|
bmdalex
force-pushed
the
feat/alert-component
branch
from
b5649ce to
8d73689
Compare
docs/src/examples/components/Alert/Variations/AlertExampleAttached.shorthand.tsx
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Alert/alertStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Alert/alertStyles.ts
Outdated
Show resolved
Hide resolved
|
NIT: I'm not sure that that |
mnajdova
reviewed
Mar 18, 2019
|
@layershifter that was my first thought as well, but as the changes are implemented in the teams theme, then whatever are the requirements for that theme should be there. If the changes were in base theme, then we could have argue about what the colors should be. I wouldn't change this currently. |
mnajdova
reviewed
Mar 18, 2019
mnajdova
reviewed
Mar 18, 2019
mnajdova
reviewed
Mar 18, 2019
mnajdova
reviewed
Mar 18, 2019
mnajdova
reviewed
Mar 18, 2019
bmdalex
force-pushed
the
feat/alert-component
branch
from
f3824b4 to
8c744fc
Compare
mnajdova
reviewed
Mar 18, 2019
mnajdova
reviewed
Mar 18, 2019
packages/react/src/themes/teams/components/Alert/alertStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Mar 18, 2019
mnajdova
reviewed
Mar 18, 2019
mnajdova
approved these changes
Mar 18, 2019
alinais
approved these changes
Mar 18, 2019
bmdalex
force-pushed
the
feat/alert-component
branch
3 times, most recently
from
72a30c2 to
f9c0904
Compare
- renamed closeButton to action; - adapted examples; - added unit tests
bmdalex
force-pushed
the
feat/alert-component
branch
from
1971b97 to
7de8cbb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alert component V1
Description
This PR resolves #1061 by implementing the
Alertcomponent.API
infoAn alert may be formatted to display information.
warningAn alert may be formatted to display a warning message.
successAn alert may be formatted to display a successful message.
dangerAn alert may be formatted to display a danger message.
attachedAn Alert can be can be formatted to attach itself to other content.
actionAn Alert can provide the user with an action.