[Release-2.0]Fix 9829 : do not report error using import, export, module augmentation in d.t.s #9870

yuit · 2016-07-21T17:10:37Z

Previously, it would enter them as buckets with no tests, which would make our test runners run *every* test. This was very obvious on machines with lots of cores.

Update authors

…-buckets runtests-parallel skips empty buckets

Remove the unused text buffer(content) from ScriptInfo

Swap q from a reference to an import

Fix #9550: exclude 'this' type parameters from unusedParameters checks.

Previously, all assignment-declarations needed to be of the same kind: either all `this.p = ...` assignments or `C.prototype.p = ...` assignments.

Fix typedef parsing issue

* Add tests and baselines * Fix incorrect emit decorated class alias when targeting es6 or higher

* Port performance tools from transforms branch * Use friendlier names, add compiler option to print all recorded measures * Always print total time * + -> .getTime

…ration error in ambient context (#9789) (#9830) * Do not report block-scoped-used-before-declaration in ambient context * Add tests and baselines

@mihailik

* Integrate feedback from @mihailik * Rons feedback, explicitly include in new tsconfigs

Make TemplateStringsArray immutable.

Fix #9843. IScriptSnapshot can return undefined

…arameters Fix emit with this and rest parameters

sheetalkamat · 2016-07-21T17:20:42Z

src/compiler/program.ts

@@ -2275,7 +2275,7 @@ namespace ts {
                    programDiagnostics.add(createFileDiagnostic(firstNonExternalModuleSourceFile, span.start, span.length, Diagnostics.Cannot_compile_namespaces_when_the_isolatedModules_flag_is_provided));
                }
            }
-            else if (firstExternalModuleSourceFile && languageVersion < ScriptTarget.ES6 && options.module === ModuleKind.None) {
+            else if (firstExternalModuleSourceFile && !isDeclarationFile(firstExternalModuleSourceFile) && languageVersion < ScriptTarget.ES6 && options.module === ModuleKind.None) {


This is not enough because for program with a.d.ts and b.ts the error wont be reported in b.ts
You technically want firstNonAmbientExternalModuleSourceFile here

Thanks @sheetalkamat will address it and add tests

mhegazy · 2016-07-21T21:49:47Z

👍

sheetalkamat · 2016-07-21T22:13:34Z

👍

This reverts commit d6b2761, reversing changes made to 33b7149.

DanielRosenwasser · 2016-07-22T07:32:17Z

Woah:exclamation:

Can you please send out a fixed-up minimal PR this that cherry picks the relevant commits? Having merged in from master will cause some issues that we don't want to need to think about. While it's doable, this will keep things cleaner.

yuit · 2016-07-22T14:16:29Z

@DanielRosenwasser yea this is a mistake (trying to do this before going to bed... 😅 ) accidentally merge master. I am going to revert it

RyanCavanaugh and others added 30 commits June 23, 2016 10:51

Add failing test

cccf70b

runtests-parallel skips empty buckets

c35e374

Previously, it would enter them as buckets with no tests, which would make our test runners run *every* test. This was very obvious on machines with lots of cores.

Create tokens using different constructor

4a77c97

Identifier constructor

a2ff4ea

Update language in comment

29985f3

Add .mailmap file

4c6b984

Add authors script to generate authors from repo

6fe105e

Update AUTHORS.md for release-2.0

8b20ad0

Update script to pass more than one argument

9ff0cab

Merge pull request #9534 from Microsoft/updateAuthors

94f2169

Update authors

Remove the unused text buffer from ScriptInfo

635826f

Set default flags on all nodes

08a0137

Merge branch 'release-2.0'

9a39f9c

Update LKG

a039412

Merge pull request #9428 from Microsoft/runtests-parallel-skips-empty…

3e42733

…-buckets runtests-parallel skips empty buckets

Swap q from a reference to an import

4b5f7e5

Fix #9550: exclude 'this' type parameters from unusedParameters checks.

1ee3f99

Merge pull request #9537 from Microsoft/removeContentFromScriptInfo

e1c69d7

Remove the unused text buffer(content) from ScriptInfo

Update comment to reflect new dependency

f9102d0

Merge pull request #9556 from weswigham/import-q

7c1df15

Swap q from a reference to an import

Merge pull request #9557 from saneyuki/fix-unusedparam-this

99748a2

Fix #9550: exclude 'this' type parameters from unusedParameters checks.

Make TemplateStringsArray completely immutable.

4de0a05

Avoid putting children tags in jsdoccomment

fd66760

Parse the result of getDirectories call

5c498cd

Update harness getDirectories implementation for shims

f0d5ff6

Fix multiple Salsa assignment-declarations

4721b91

Previously, all assignment-declarations needed to be of the same kind: either all `this.p = ...` assignments or `C.prototype.p = ...` assignments.

Test for multiple salsa assignment-declarations

f84b731

Add test for parsed @typedef tag node shape

ebc75a2

Merge pull request #9565 from zhengbli/fixTypedefParsingIssue

81e8840

Fix typedef parsing issue

Provide a symbol for salsa-inferred class types

3c1a69b

mhegazy and others added 13 commits July 18, 2016 14:56

Update LKG

ac72aff

Merge branch 'mergerRelease-2.0InMaster'

32a9196

Port Fix9685 to master (#9788)

e52e165

* Add tests and baselines * Fix incorrect emit decorated class alias when targeting es6 or higher

Add performance framework from transforms branch (#9536)

2a26beb

* Port performance tools from transforms branch * Use friendlier names, add compiler option to print all recorded measures * Always print total time * + -> .getTime

[Release-2.0] Fix 9782: do not report blocked-scope-used-before-decla…

80db0f2

…ration error in ambient context (#9789) (#9830) * Do not report block-scoped-used-before-declaration in ambient context * Add tests and baselines

Integrate feedback from @mihailik to performance framework (#9845)

729464d

* Integrate feedback from @mihailik * Rons feedback, explicitly include in new tsconfigs

Merge branch 'master' into tsaImmutable

82de932

Fix #9843. IScriptSnapshot can return undefined

1b07fbb

Merge pull request #9561 from Microsoft/tsaImmutable

6e4dd75

Make TemplateStringsArray immutable.

Merge pull request #9853 from HerringtonDarkholme/master

a2f45e9

Fix #9843. IScriptSnapshot can return undefined

Merge pull request #9692 from Microsoft/fix-emit-with-this-and-rest-p…

57eac1b

…arameters Fix emit with this and rest parameters

Only error in non-declaration file

adff787

Add tests and baselines

7d16935

msftclas added the cla-not-required label Jul 21, 2016

sheetalkamat reviewed Jul 21, 2016
View reviewed changes

sudheesh001 and others added 4 commits July 21, 2016 12:25

Remove dependency on tsd, Related to #9658 (#9724)

f24341f

Addess PR: get the first non-ambient external module file

395e6c9

Rename test file and update baseline

03eb4ac

Add tests and baselines

33b7149

Yui T added 3 commits July 21, 2016 21:17

Merge branch 'master' into fix9829

d6b2761

Update baselines

398e65e

Revert "Merge branch 'master' into fix9829"

856c89c

This reverts commit d6b2761, reversing changes made to 33b7149.

yuit mentioned this pull request Jul 22, 2016

[Release-2.0] Fix 9829 : do not report error using import, export, module augmentation in d.t.s #9894

Merged

yuit closed this Jul 22, 2016

yuit deleted the fix9829 branch July 22, 2016 15:02

microsoft locked and limited conversation to collaborators Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release-2.0]Fix 9829 : do not report error using import, export, module augmentation in d.t.s #9870

[Release-2.0]Fix 9829 : do not report error using import, export, module augmentation in d.t.s #9870

yuit commented Jul 21, 2016

sheetalkamat Jul 21, 2016

yuit Jul 21, 2016

mhegazy commented Jul 21, 2016

sheetalkamat commented Jul 21, 2016

DanielRosenwasser commented Jul 22, 2016 •

edited

Loading

yuit commented Jul 22, 2016

[Release-2.0]Fix 9829 : do not report error using import, export, module augmentation in d.t.s #9870

[Release-2.0]Fix 9829 : do not report error using import, export, module augmentation in d.t.s #9870

Conversation

yuit commented Jul 21, 2016

sheetalkamat Jul 21, 2016

Choose a reason for hiding this comment

yuit Jul 21, 2016

Choose a reason for hiding this comment

mhegazy commented Jul 21, 2016

sheetalkamat commented Jul 21, 2016

DanielRosenwasser commented Jul 22, 2016 • edited Loading

yuit commented Jul 22, 2016

DanielRosenwasser commented Jul 22, 2016 •

edited

Loading