Skip to content

Remove the unused text buffer(content) from ScriptInfo #9537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2016
Merged

Remove the unused text buffer(content) from ScriptInfo #9537

merged 1 commit into from
Jul 7, 2016

Conversation

sheetalkamat
Copy link
Member

This removes the reference to source text from ScriptInfo

@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2016

👍

@vladima
Copy link
Contributor

vladima commented Jul 6, 2016

👍
also to mention that matching change was already made in tsserver migration work

@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2016

@sheetalkamat can you port this to the release-2.0 branch?

@sheetalkamat sheetalkamat merged commit e1c69d7 into master Jul 7, 2016
@sheetalkamat sheetalkamat deleted the removeContentFromScriptInfo branch July 7, 2016 17:26
@sheetalkamat
Copy link
Member Author

@mhegazy done as 28938fb

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheetalkamat @mhegazy @vladima @msftclas