Fix emit with this and rest parameters #9692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also test that it's skipped when emitting decorator metadata
| @@ -6155,10 +6156,11 @@ const _super = (function (geti, seti) { | |||
|
|
|||
| if (valueDeclaration) { | |||
| const parameters = valueDeclaration.parameters; | |||
| const skipThisCount = parameters.length && (<Identifier>parameters[0].name).text === "this" ? 1 : 0; | |||
There was a problem hiding this comment.
parameters[0].originalKeywordKind === SyntaxKind.ThisKeyword
|
@mhegazy are you OK with merging this now? |
|
👍 |
|
We will need to merge this in release-2.0 as well. |
|
Done. I cherry-picked the commits into release-2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9682
and also fixes the same problem when emitting decorator metadata.