Skip to content

Fix issue with find references for jsx tags #7622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2016

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Mar 21, 2016

For JSX elements with tagnames consistent of only identifiers, calling checkExpression, does not do what the language service expects, so find all references will not work correctly.

//CC: @RyanCavanaugh

@DanielRosenwasser
Copy link
Member

👍

1 similar comment
@RyanCavanaugh
Copy link
Member

👍

mhegazy added a commit that referenced this pull request Mar 21, 2016
Fix issue with find references for jsx tags
@mhegazy mhegazy merged commit 7c99c8f into master Mar 21, 2016
@mhegazy mhegazy deleted the findAllReferencesForJSXTagNames branch March 21, 2016 23:28
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants