getDocumentHighlights does not return uses of SFCs in JSX elements

[myitcv]

This issue first surfaced in palantir/tslint#972

I think the following is a minimal reproduction of the problem:

/// <reference path='fourslash.ts' />

//@Filename: file.tsx
//// export function BuildMyComponent(): JSX.Element {
////    let [|StringComponentA|]: React.ComponentClass<{}>;
////    return <[|StringCom/**/ponentA|] />;
//// }

The issue first surfaced in 1.9.0-dev.20160212; indeed I think I've bisected the problem to 13167f5 using the above test

[myitcv]

@mhegazy @RyanCavanaugh - anyone using tslint with the no-unused-variable rule (and React) is currently blocked from upgrading past 1.9.0-dev.20160212 (details palantir/tslint#972) because of this issue.

Is there any chance therefore that this could be addressed before the 2.0 milestone?

That would then allow us to pick up and test things like private constructors which landed in more recent nightlies.

Thanks in advance

[RyanCavanaugh]

We'd take a PR at any time but I have other more urgent work at the moment. It'll probably be a week or two before I get to this.

[myitcv]

Thanks Ryan
On 29 Feb 2016 21:29, "Ryan Cavanaugh" notifications@github.com wrote:

We'd take a PR at any time but I have other more urgent work at the
moment. It'll probably be a week or two before I get to this.

—
Reply to this email directly or view it on GitHub
#7109 (comment)
.

[myitcv]

Confirmed this is fixed by #7622 (thanks @mhegazy) available as of 1.9.0-dev.20160322