Skip to content

Find References and Dotted JSX Tags #7637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkillian opened this issue Mar 22, 2016 · 2 comments · Fixed by #7645
Closed

Find References and Dotted JSX Tags #7637

jkillian opened this issue Mar 22, 2016 · 2 comments · Fixed by #7645
Assignees
Labels
Bug A bug in TypeScript Domain: JSX/TSX Relates to the JSX parser and emitter Fixed A PR has been merged for this issue

Comments

@jkillian
Copy link

TypeScript Version:
1.9.0-dev.20160322

Code

/// <reference path='fourslash.ts'/>

// @Filename: index.tsx
////const /*1*/obj = {Component: () => <div/>};
////const element = </*2*/obj.Component/>;

goTo.marker("1");
verify.referencesCountIs(2);

goTo.marker("2");
verify.referencesCountIs(2);

Expected behavior:
Test passes

Actual behavior:
Test fails: reference count is 1 at marker 1 and is 0 at marker 2.

Notes:
#7622 was great and seemed to fix a lot of bugs! It seems that this one still persists though, as found by @dallonf in palantir/tslint#1010

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: JSX/TSX Relates to the JSX parser and emitter labels Mar 22, 2016
mhegazy added a commit that referenced this issue Mar 23, 2016
Fix #7637: treat jsx tag names as expressions
@mhegazy
Copy link
Contributor

mhegazy commented Mar 23, 2016

@jkillian can you give tomorrow's nightly a try.

@mhegazy mhegazy added this to the TypeScript 2.0 milestone Mar 23, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 23, 2016
@mhegazy mhegazy self-assigned this Mar 23, 2016
@jkillian
Copy link
Author

jkillian commented Apr 6, 2016

@mhegazy Thanks! This seems to have fixed things, sorry for the delay in response.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: JSX/TSX Relates to the JSX parser and emitter Fixed A PR has been merged for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants