Simplify abstract constructor type assignability checking #6111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15396,20 +15368,6 @@ namespace ts { | |||
| return symbol && getExportSymbolOfValueSymbolIfExported(symbol).valueDeclaration; | |||
| } | |||
|
|
|||
| function instantiateSingleCallFunctionType(functionType: Type, typeArguments: Type[]): Type { | |||
There was a problem hiding this comment.
we don't lint unused functions?
|
:1+: |
| @@ -5782,6 +5740,20 @@ namespace ts { | |||
| } | |||
| } | |||
|
|
|||
| // Return true if the given type is the constructor type for an abstract class | |||
| function isAbstractConstructorType(type: Type) { | |||
| if (type.flags & TypeFlags.Anonymous) { | |||
There was a problem hiding this comment.
Can you elaborate why this needs to be anonymous?
There was a problem hiding this comment.
Because the static side of a class is an anonymous object type.
There was a problem hiding this comment.
Can you add that in as a quick comment then? It's not entirely obvious at first glance.
|
Other than my last comment, 👍 |
ahejlsberg
added a commit
that referenced
this pull request
Dec 19, 2015
Simplify abstract constructor type assignability checking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies checking of abstract constructor type assignability. The current code is overly convoluted and inefficient and even includes some out of bounds indexing of arrays.