Apply the 'no-unused-variable' tslint rule to our codebase #6140
Conversation
|
That is lots of unused stuffs |
| @@ -583,7 +555,9 @@ namespace ts.server { | |||
| } | |||
|
|
|||
| handleProjectFilelistChanges(project: Project) { | |||
| const { succeeded, projectOptions, error } = this.configFileToProjectOptions(project.projectFilename); | |||
| // TODO: Ignoring potentially returned 'error' and 'succeeded' condition | |||
There was a problem hiding this comment.
what is this Todo for? you already ignore error and succeeded?
There was a problem hiding this comment.
I guess if there's a problem, it'll get fixed at that point. No sense leaving the comment.
|
👍 |
Apply the 'no-unused-variable' tslint rule to our codebase
|
👍 |
| if (defaultLibFileName) { | ||
| for (const current of declarations) { | ||
| const sourceFile = current.getSourceFile(); | ||
| // TODO (drosen): When is there no source file? |
There was a problem hiding this comment.
To answer the comment: When you've fooled the language service by injecting a declaration node which is not parented to anything, yet is associated with a symbol returned by getSymbolAtLocation - which could conceivably happen if you wrapped the language service and injected declarations for templated components, but have not rewritten the getSourceFile implementation to do something other than walk up the tree? TBH, it probably never happens under normal conditions and is likely exceptional - every node should be nested within a source file in a well-behaved program. Maybe it would be more correct to toss in a Debug.fail here, despite that not being the old behavior?
There is also a
check-parametersoption, but that would've been a much bigger, less reviewable change.