Fix incorrect lib condition again! #58945

sheetalkamat · 2024-06-20T17:53:59Z

Reiteration of #58867

sheetalkamat · 2024-06-20T17:54:08Z

typescript-bot · 2024-06-20T17:54:11Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey

I was tempted to send effectively this exact PR but didn't after being confused by the missing lib stuff in vscode, oops.

jakebailey · 2024-06-20T18:02:06Z

Oh I'm silly, I did, I sent #58932.

typescript-bot · 2024-06-20T18:17:25Z

Hey @sheetalkamat, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-06-20T18:22:25Z

@sheetalkamat Here are the results of running the user tests with tsc comparing main and refs/pull/58945/merge:

Everything looks good!

typescript-bot · 2024-06-20T18:29:55Z

@sheetalkamat
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,804k (± 0.75%)}	_{193,369k (± 0.94%)}	_~	_192,081k	_195,734k	_{p=0.873 n=6}
_{Parse Time}	_{1.31s (± 1.56%)}	_{1.30s (± 0.97%)}	_~	_1.28s	_1.31s	_{p=0.232 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.48s (± 0.34%)}	_{9.44s (± 0.50%)}	_~	_9.40s	_9.53s	_{p=0.148 n=6}
_{Emit Time}	_{2.75s (± 0.50%)}	_{2.73s (± 0.91%)}	_~	_2.68s	_2.75s	_{p=0.161 n=6}
_{Total Time}	_{14.24s (± 0.29%)}	_{14.18s (± 0.45%)}	_~	_14.07s	_14.26s	_{p=0.091 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,325k (± 0.00%)}	_{1,218,329k (± 0.00%)}	_~	_1,218,282k	_1,218,380k	_{p=0.873 n=6}
_{Parse Time}	_{7.96s (± 0.34%)}	_{7.95s (± 0.38%)}	_~	_7.91s	_7.99s	_{p=0.466 n=6}
_{Bind Time}	_{2.24s (± 0.47%)}	_{2.23s (± 0.77%)}	_~	_2.20s	_2.25s	_{p=0.564 n=6}
_{Check Time}	_{35.77s (± 0.18%)}	_{35.76s (± 0.33%)}	_~	_35.57s	_35.91s	_{p=1.000 n=6}
_{Emit Time}	_{16.14s (± 0.32%)}	_{16.10s (± 0.98%)}	_~	_15.81s	_16.28s	_{p=0.747 n=6}
_{Total Time}	_{62.10s (± 0.14%)}	_{62.03s (± 0.31%)}	_~	_61.79s	_62.24s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,134,309	_2,134,309	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,039	_927,039	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,888k (± 0.00%)}	_{2,115,916k (± 0.00%)}	_~	_2,115,816k	_2,116,077k	_{p=0.810 n=6}
_{Parse Time}	_{6.59s (± 0.27%)}	_{6.59s (± 0.51%)}	_~	_6.54s	_6.64s	_{p=0.627 n=6}
_{Bind Time}	_{2.32s (± 0.39%)}	_{2.34s (± 1.25%)}	_~	_2.30s	_2.39s	_{p=0.119 n=6}
_{Check Time}	_{70.71s (± 0.46%)}	_{70.50s (± 0.95%)}	_~	_69.28s	_71.10s	_{p=0.575 n=6}
_{Emit Time}	_{0.13s (± 3.87%)}	_{0.14s (± 4.05%)}	_~	_0.13s	_0.14s	_{p=0.640 n=6}
_{Total Time}	_{79.75s (± 0.41%)}	_{79.56s (± 0.77%)}	_~	_78.44s	_80.12s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,692	_1,230,796	_{+104 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,165	_261,195	_{+30 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,354,930k (± 1.01%)}	_{2,345,311k (± 0.02%)}	_~	_2,344,467k	_2,345,838k	_{p=0.575 n=6}
_{Parse Time}	_{4.96s (± 0.61%)}	_{5.02s (± 1.09%)}	_~	_4.95s	_5.10s	_{p=0.054 n=6}
_{Bind Time}	_{1.91s (± 0.81%)}	_{1.91s (± 1.01%)}	_~	_1.90s	_1.95s	_{p=1.000 n=6}
_{Check Time}	_{33.67s (± 0.19%)}	_{33.75s (± 0.32%)}	_~	_33.57s	_33.85s	_{p=0.199 n=6}
_{Emit Time}	_{2.74s (± 1.76%)}	_{2.69s (± 2.45%)}	_~	_2.59s	_2.79s	_{p=0.148 n=6}
_{Total Time}	_{43.31s (± 0.17%)}	_{43.38s (± 0.34%)}	_~	_43.15s	_43.52s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,692	_1,230,796	_{+104 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,165	_261,195	_{+30 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,432,356k (± 0.98%)}	_{2,421,975k (± 0.03%)}	_{-10,381k (- 0.43%)}	_2,420,448k	_2,422,599k	_{p=0.031 n=6}
_{Parse Time}	_{6.18s (± 1.14%)}	_{6.18s (± 1.00%)}	_~	_6.13s	_6.28s	_{p=0.810 n=6}
_{Bind Time}	_{2.02s (± 1.31%)}	_{2.02s (± 1.43%)}	_~	_1.96s	_2.04s	_{p=0.688 n=6}
_{Check Time}	_{40.09s (± 0.33%)}	_{40.04s (± 0.21%)}	_~	_39.94s	_40.16s	_{p=0.521 n=6}
_{Emit Time}	_{3.16s (± 1.61%)}	_{3.20s (± 2.03%)}	_~	_3.13s	_3.28s	_{p=0.261 n=6}
_{Total Time}	_{51.45s (± 0.25%)}	_{51.43s (± 0.31%)}	_~	_51.27s	_51.65s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,573	_258,574	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,819	_104,819	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,127k (± 0.01%)}	_{428,174k (± 0.01%)}	_{+47k (+ 0.01%)}	_428,129k	_428,227k	_{p=0.045 n=6}
_{Parse Time}	_{2.76s (± 0.59%)}	_{2.75s (± 1.07%)}	_~	_2.72s	_2.80s	_{p=0.686 n=6}
_{Bind Time}	_{1.10s (± 0.94%)}	_{1.12s (± 1.46%)}	_{+0.02s (+ 1.82%)}	_1.09s	_1.14s	_{p=0.035 n=6}
_{Check Time}	_{15.06s (± 0.48%)}	_{15.08s (± 0.36%)}	_~	_15.02s	_15.15s	_{p=0.463 n=6}
_{Emit Time}	_{1.15s (± 0.90%)}	_{1.16s (± 1.70%)}	_~	_1.13s	_1.18s	_{p=0.359 n=6}
_{Total Time}	_{20.05s (± 0.33%)}	_{20.10s (± 0.35%)}	_~	_20.03s	_20.21s	_{p=0.173 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,469k (± 0.02%)}	_{369,493k (± 0.03%)}	_~	_369,359k	_369,615k	_{p=0.471 n=6}
_{Parse Time}	_{3.45s (± 0.99%)}	_{3.46s (± 1.28%)}	_~	_3.39s	_3.50s	_{p=0.627 n=6}
_{Bind Time}	_{1.93s (± 0.89%)}	_{1.93s (± 0.39%)}	_~	_1.92s	_1.94s	_{p=0.672 n=6}
_{Check Time}	_{19.11s (± 0.24%)}	_{19.09s (± 0.21%)}	_~	_19.01s	_19.13s	_{p=0.170 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.49s (± 0.29%)}	_{24.47s (± 0.16%)}	_~	_24.43s	_24.52s	_{p=0.463 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₃₉	₁₃₉	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,847,449	_2,847,449	_~	_~	_~	_{p=1.000 n=6}
_Types	_974,045	_974,045	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,040,068k (± 0.00%)}	_{3,040,110k (± 0.00%)}	_~	_3,040,024k	_3,040,198k	_{p=0.230 n=6}
_{Parse Time}	_{13.50s (± 0.21%)}	_{13.54s (± 0.25%)}	_~	_13.52s	_13.61s	_{p=0.061 n=6}
_{Bind Time}	_{4.16s (± 0.29%)}	_{4.16s (± 0.64%)}	_~	_4.14s	_4.21s	_{p=0.796 n=6}
_{Check Time}	_{73.56s (± 0.39%)}	_{73.64s (± 0.30%)}	_~	_73.38s	_73.92s	_{p=0.689 n=6}
_{Emit Time}	_{23.91s (± 0.13%)}	_{23.92s (± 0.67%)}	_~	_23.70s	_24.17s	_{p=1.000 n=6}
_{Total Time}	_{115.13s (± 0.26%)}	_{115.26s (± 0.12%)}	_~	_115.10s	_115.50s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,116	_267,116	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,758	_108,758	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,640k (± 0.04%)}	_{411,661k (± 0.02%)}	_~	_411,575k	_411,769k	_{p=0.689 n=6}
_{Parse Time}	_{4.70s (± 0.30%)}	_{4.72s (± 0.65%)}	_~	_4.70s	_4.77s	_{p=0.244 n=6}
_{Bind Time}	_{2.09s (± 0.70%)}	_{2.09s (± 0.58%)}	_~	_2.07s	_2.10s	_{p=0.934 n=6}
_{Check Time}	_{20.82s (± 0.30%)}	_{20.83s (± 0.76%)}	_~	_20.68s	_21.08s	_{p=0.689 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.61s (± 0.24%)}	_{27.64s (± 0.71%)}	_~	_27.46s	_27.93s	_{p=0.689 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,765	_523,765	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,055	_178,055	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,815k (± 0.07%)}	_{461,913k (± 0.09%)}	_~	_461,369k	_462,314k	_{p=0.575 n=6}
_{Parse Time}	_{3.18s (± 0.65%)}	_{3.18s (± 0.54%)}	_~	_3.16s	_3.21s	_{p=0.935 n=6}
_{Bind Time}	_{1.18s (± 0.71%)}	_{1.18s (± 0.35%)}	_~	_1.18s	_1.19s	_{p=0.527 n=6}
_{Check Time}	_{18.04s (± 0.38%)}	_{17.96s (± 0.26%)}	_~	_17.90s	_18.01s	_{p=0.065 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.40s (± 0.37%)}	_{22.33s (± 0.25%)}	_~	_22.25s	_22.39s	_{p=0.093 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

tests/baselines/reference/tsc/libraryResolution/with-config-with-redirection.js

typescript-bot · 2024-06-20T20:02:02Z

@sheetalkamat Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58945/merge:

Everything looks good!

sheetalkamat added 2 commits June 20, 2024 10:50

Test

fd0f89c

Fix incorrect lib condition

628e440

typescript-bot assigned sheetalkamat Jun 20, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 20, 2024

sheetalkamat requested review from andrewbranch and jakebailey June 20, 2024 17:54

Fix lint

460f166

sheetalkamat mentioned this pull request Jun 20, 2024

Fix crash in isSourceFileDefaultLibrary for vscode benchmark #58932

Closed

jakebailey approved these changes Jun 20, 2024

View reviewed changes

Missed baseline

da008c9

sheetalkamat commented Jun 20, 2024

View reviewed changes

tests/baselines/reference/tsc/libraryResolution/with-config-with-redirection.js Show resolved Hide resolved

sheetalkamat merged commit beb375a into main Jun 20, 2024
28 checks passed

sheetalkamat deleted the noLibCheckRetry branch June 20, 2024 20:18

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect lib condition again! #58945

Fix incorrect lib condition again! #58945

sheetalkamat commented Jun 20, 2024

sheetalkamat commented Jun 20, 2024

typescript-bot commented Jun 20, 2024 •

edited

Loading

jakebailey left a comment

jakebailey commented Jun 20, 2024

typescript-bot commented Jun 20, 2024

typescript-bot commented Jun 20, 2024

typescript-bot commented Jun 20, 2024

tsc

typescript-bot commented Jun 20, 2024

Fix incorrect lib condition again! #58945

Fix incorrect lib condition again! #58945

Conversation

sheetalkamat commented Jun 20, 2024

sheetalkamat commented Jun 20, 2024

typescript-bot commented Jun 20, 2024 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

jakebailey commented Jun 20, 2024

typescript-bot commented Jun 20, 2024

typescript-bot commented Jun 20, 2024

typescript-bot commented Jun 20, 2024

tsc

typescript-bot commented Jun 20, 2024

typescript-bot commented Jun 20, 2024 •

edited

Loading