Fix crash in isSourceFileDefaultLibrary for vscode benchmark #58932

jakebailey · 2024-06-19T17:53:25Z

I am not 100% certain how to test this, but the benchmark should show that this fixes things.

jakebailey · 2024-06-19T17:53:40Z

typescript-bot · 2024-06-19T17:53:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-06-19T18:35:48Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,769k (± 0.75%)}	_{192,799k (± 0.76%)}	_~	_192,110k	_195,760k	_{p=0.298 n=6}
_{Parse Time}	_{1.31s (± 0.62%)}	_{1.31s (± 0.57%)}	_~	_1.30s	_1.32s	_{p=0.340 n=6}
_{Bind Time}	_0.71s	_{0.71s (± 0.57%)}	_~	_0.71s	_0.72s	_{p=0.405 n=6}
_{Check Time}	_{9.43s (± 0.66%)}	_{9.42s (± 0.19%)}	_~	_9.39s	_9.44s	_{p=0.748 n=6}
_{Emit Time}	_{2.75s (± 0.40%)}	_{2.75s (± 0.46%)}	_~	_2.73s	_2.76s	_{p=0.932 n=6}
_{Total Time}	_{14.20s (± 0.41%)}	_{14.19s (± 0.16%)}	_~	_14.17s	_14.23s	_{p=0.747 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,379k (± 0.01%)}	_{1,218,346k (± 0.00%)}	_~	_1,218,284k	_1,218,398k	_{p=0.471 n=6}
_{Parse Time}	_{6.66s (± 0.86%)}	_{6.67s (± 0.59%)}	_~	_6.60s	_6.71s	_{p=0.573 n=6}
_{Bind Time}	_{1.86s (± 0.71%)}	_{1.85s (± 0.74%)}	_~	_1.84s	_1.87s	_{p=0.367 n=6}
_{Check Time}	_{30.65s (± 0.49%)}	_{30.57s (± 0.20%)}	_~	_30.51s	_30.67s	_{p=0.228 n=6}
_{Emit Time}	_{13.54s (± 0.28%)}	_{13.58s (± 0.74%)}	_~	_13.48s	_13.77s	_{p=0.378 n=6}
_{Total Time}	_{52.71s (± 0.21%)}	_{52.68s (± 0.30%)}	_~	_52.44s	_52.87s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,539	_2,133,539	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,551	_926,551	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,740k (± 0.00%)}	_{2,115,832k (± 0.01%)}	_~	_2,115,735k	_2,115,980k	_{p=0.066 n=6}
_{Parse Time}	_{6.61s (± 0.23%)}	_{6.62s (± 0.41%)}	_~	_6.59s	_6.65s	_{p=0.628 n=6}
_{Bind Time}	_{2.33s (± 0.22%)}	_{2.35s (± 1.72%)}	_~	_2.30s	_2.40s	_{p=0.797 n=6}
_{Check Time}	_{70.85s (± 0.15%)}	_{70.08s (± 1.62%)}	_~	_68.25s	_71.17s	_{p=0.378 n=6}
_{Emit Time}	_{0.14s (± 4.05%)}	_{0.13s (± 3.10%)}	_~	_0.13s	_0.14s	_{p=0.282 n=6}
_{Total Time}	_{79.94s (± 0.14%)}	_{79.18s (± 1.36%)}	_~	_77.43s	_80.23s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,761	_1,230,761	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,189	_261,189	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,346,158k (± 0.04%)}	_{2,345,097k (± 0.04%)}	_~	_2,344,050k	_2,346,462k	_{p=0.093 n=6}
_{Parse Time}	_{4.99s (± 0.81%)}	_{5.00s (± 0.71%)}	_~	_4.93s	_5.03s	_{p=0.810 n=6}
_{Bind Time}	_{1.90s (± 0.79%)}	_{1.90s (± 0.98%)}	_~	_1.88s	_1.93s	_{p=1.000 n=6}
_{Check Time}	_{33.78s (± 0.19%)}	_{33.81s (± 0.35%)}	_~	_33.65s	_33.91s	_{p=0.688 n=6}
_{Emit Time}	_{2.69s (± 3.11%)}	_{2.74s (± 3.31%)}	_~	_2.62s	_2.88s	_{p=0.336 n=6}
_{Total Time}	_{43.39s (± 0.29%)}	_{43.47s (± 0.37%)}	_~	_43.26s	_43.69s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,761	_1,230,761	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,189	_261,189	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,423,503k (± 0.02%)}	_{2,423,298k (± 0.03%)}	_~	_2,422,510k	_2,424,099k	_{p=0.936 n=6}
_{Parse Time}	_{6.22s (± 1.06%)}	_{6.22s (± 0.56%)}	_~	_6.18s	_6.26s	_{p=0.810 n=6}
_{Bind Time}	_{2.03s (± 1.57%)}	_{2.01s (± 0.41%)}	_~	_2.01s	_2.03s	_{p=0.317 n=6}
_{Check Time}	_{40.21s (± 0.19%)}	_{40.17s (± 0.21%)}	_~	_40.03s	_40.25s	_{p=0.378 n=6}
_{Emit Time}	_{3.15s (± 1.29%)}	_{3.19s (± 2.34%)}	_~	_3.11s	_3.28s	_{p=0.575 n=6}
_{Total Time}	_{51.62s (± 0.20%)}	_{51.63s (± 0.19%)}	_~	_51.44s	_51.70s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,573	_258,573	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,819	_104,819	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,151k (± 0.01%)}	_{428,184k (± 0.02%)}	_~	_428,112k	_428,326k	_{p=0.689 n=6}
_{Parse Time}	_{3.31s (± 0.87%)}	_{3.32s (± 0.56%)}	_~	_3.30s	_3.35s	_{p=0.410 n=6}
_{Bind Time}	_{1.31s (± 1.63%)}	_{1.32s (± 1.30%)}	_~	_1.29s	_1.34s	_{p=0.324 n=6}
_{Check Time}	_{17.74s (± 0.40%)}	_{17.73s (± 0.22%)}	_~	_17.68s	_17.78s	_{p=0.810 n=6}
_{Emit Time}	_{1.37s (± 2.42%)}	_{1.37s (± 0.92%)}	_~	_1.36s	_1.39s	_{p=0.870 n=6}
_{Total Time}	_{23.72s (± 0.41%)}	_{23.74s (± 0.22%)}	_~	_23.67s	_23.82s	_{p=0.520 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,592k (± 0.04%)}	_{369,566k (± 0.02%)}	_~	_369,405k	_369,680k	_{p=0.810 n=6}
_{Parse Time}	_{2.76s (± 1.11%)}	_{2.76s (± 0.60%)}	_~	_2.73s	_2.77s	_{p=0.935 n=6}
_{Bind Time}	_{1.58s (± 0.33%)}	_{1.59s (± 1.52%)}	_~	_1.57s	_1.63s	_{p=0.143 n=6}
_{Check Time}	_{15.45s (± 0.25%)}	_{15.46s (± 0.46%)}	_~	_15.40s	_15.60s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.79s (± 0.19%)}	_{19.81s (± 0.49%)}	_~	_19.71s	_19.99s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₁₃₉	_~	_~	_~	_{p=1.000 n=0+6}
_Symbols	₀	_2,846,176	_~	_~	_~	_{p=1.000 n=0+6}
_Types	₀	_973,687	_~	_~	_~	_{p=1.000 n=0+6}
_{Memory used}	_0k	_{3,038,754k (± 0.00%)}	_~	_3,038,685k	_3,038,827k	_{p=1.000 n=0+6}
_{Parse Time}	_0s	_{16.71s (± 0.44%)}	_~	_16.64s	_16.85s	_{p=1.000 n=0+6}
_{Bind Time}	_0s	_{5.11s (± 0.72%)}	_~	_5.06s	_5.17s	_{p=1.000 n=0+6}
_{Check Time}	_0s	_{90.74s (± 1.85%)}	_~	_89.82s	_94.16s	_{p=1.000 n=0+6}
_{Emit Time}	_0s	_{28.60s (± 6.50%)}	_~	_24.80s	_29.44s	_{p=1.000 n=0+6}
_{Total Time}	_0s	_{141.16s (± 0.23%)}	_~	_140.65s	_141.54s	_{p=1.000 n=0+6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,932	_266,932	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,691	_108,691	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,272k (± 0.01%)}	_{411,312k (± 0.02%)}	_~	_411,219k	_411,395k	_{p=0.378 n=6}
_{Parse Time}	_{3.79s (± 0.48%)}	_{3.80s (± 0.50%)}	_~	_3.78s	_3.82s	_{p=0.277 n=6}
_{Bind Time}	_{1.68s (± 0.24%)}	_{1.67s (± 0.70%)}	_{-0.01s (- 0.79%)}	_1.65s	_1.68s	_{p=0.025 n=6}
_{Check Time}	_{16.77s (± 0.51%)}	_{16.73s (± 0.28%)}	_~	_16.65s	_16.78s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.25s (± 0.42%)}	_{22.20s (± 0.23%)}	_~	_22.12s	_22.26s	_{p=0.377 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,765	_523,765	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,055	_178,055	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,688k (± 0.08%)}	_{461,957k (± 0.07%)}	_~	_461,380k	_462,246k	_{p=0.173 n=6}
_{Parse Time}	_{3.18s (± 1.01%)}	_{3.18s (± 0.26%)}	_~	_3.17s	_3.19s	_{p=0.934 n=6}
_{Bind Time}	_{1.18s (± 0.64%)}	_{1.18s (± 0.93%)}	_~	_1.16s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{17.98s (± 0.43%)}	_{18.02s (± 0.32%)}	_~	_17.93s	_18.07s	_{p=0.376 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.33s (± 0.45%)}	_{22.37s (± 0.31%)}	_~	_22.28s	_22.44s	_{p=0.469 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-06-19T18:43:30Z

Now that the bench is running, this points out a bunch of errors that show up in vscode that did not before.

sheetalkamat

#58945 is correct change

Fix crash in isSourceFileDefaultLibrary for vscode benchmark

090e7b9

jakebailey requested a review from sheetalkamat June 19, 2024 17:53

typescript-bot assigned jakebailey Jun 19, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 19, 2024

sheetalkamat requested changes Jun 20, 2024

View reviewed changes

jakebailey mentioned this pull request Jun 20, 2024

Fix incorrect lib condition again! #58945

Merged

jakebailey closed this Jun 20, 2024

jakebailey deleted the fix-vscode-crash branch June 20, 2024 18:02

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash in isSourceFileDefaultLibrary for vscode benchmark #58932

Fix crash in isSourceFileDefaultLibrary for vscode benchmark #58932

jakebailey commented Jun 19, 2024

jakebailey commented Jun 19, 2024

typescript-bot commented Jun 19, 2024 •

edited

Loading

typescript-bot commented Jun 19, 2024

tsc

jakebailey commented Jun 19, 2024

sheetalkamat left a comment

Fix crash in isSourceFileDefaultLibrary for vscode benchmark #58932

Fix crash in isSourceFileDefaultLibrary for vscode benchmark #58932

Conversation

jakebailey commented Jun 19, 2024

jakebailey commented Jun 19, 2024

typescript-bot commented Jun 19, 2024 • edited Loading

typescript-bot commented Jun 19, 2024

tsc

jakebailey commented Jun 19, 2024

sheetalkamat left a comment

Choose a reason for hiding this comment

typescript-bot commented Jun 19, 2024 •

edited

Loading