Don't run linter after tests runs #50597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
I'm going to split this PR in two; the cleanups can be unrelated to not running the linter and I have noticed other eslint problems to fix in the meantime. |
Merged
jakebailey
force-pushed
the
remove-post-test-lint
branch
from
744dc89 to
e958b4d
Compare
jakebailey
changed the title
andrewbranch
approved these changes
Sep 7, 2022
sandersn
approved these changes
Sep 12, 2022
|
Coming back to this over the weekend, I think what I should actually do is default |
|
I think you can build that yourself from |
|
Ah, duh, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From everything I've heard from the team, everyone either hits Ctrl+C once the tests pass, or explicitly passes
--lint=false. Remove the post-test task that runs linting; in a previous PR I moved linting to a separate CI job, so failing to fix a lint won't break a PRs tests (and will fail fast otherwise).