Skip to content

Commit e958b4d

Browse files
committed
Remove --lint flag
1 parent 5c2f770 commit e958b4d

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- run: npm ci
3333

3434
- name: Tests
35-
run: npm test -- --no-lint
35+
run: npm test
3636

3737
lint:
3838
runs-on: ubuntu-latest

Gulpfile.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -427,10 +427,8 @@ task("watch-local").flags = {
427427
const preTest = parallel(buildTsc, buildTests, buildServices, buildLssl);
428428
preTest.displayName = "preTest";
429429

430-
const postTest = (done) => cmdLineOptions.lint ? lint() : done();
431-
432430
const runTests = () => runConsoleTests("built/local/run.js", "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ false);
433-
task("runtests", series(preBuild, preTest, runTests, postTest));
431+
task("runtests", series(preBuild, preTest, runTests));
434432
task("runtests").description = "Runs the tests using the built run.js file.";
435433
task("runtests").flags = {
436434
"-t --tests=<regex>": "Pattern for tests to run.",
@@ -442,18 +440,16 @@ task("runtests").flags = {
442440
" --dirty": "Run tests without first cleaning test output directories",
443441
" --stackTraceLimit=<limit>": "Sets the maximum number of stack frames to display. Use 'full' to show all frames.",
444442
" --no-color": "Disables color",
445-
" --no-lint": "Disables lint",
446443
" --timeout=<ms>": "Overrides the default test timeout.",
447444
" --built": "Compile using the built version of the compiler.",
448445
" --shards": "Total number of shards running tests (default: 1)",
449446
" --shardId": "1-based ID of this shard (default: 1)",
450447
};
451448

452449
const runTestsParallel = () => runConsoleTests("built/local/run.js", "min", /*runInParallel*/ cmdLineOptions.workers > 1, /*watchMode*/ false);
453-
task("runtests-parallel", series(preBuild, preTest, runTestsParallel, postTest));
450+
task("runtests-parallel", series(preBuild, preTest, runTestsParallel));
454451
task("runtests-parallel").description = "Runs all the tests in parallel using the built run.js file.";
455452
task("runtests-parallel").flags = {
456-
" --no-lint": "disables lint.",
457453
" --light": "Run tests in light mode (fewer verifications, but tests run faster).",
458454
" --keepFailed": "Keep tests in .failed-tests even if they pass.",
459455
" --dirty": "Run tests without first cleaning test output directories.",
@@ -616,7 +612,6 @@ task("watch").flags = {
616612
" --dirty": "Run tests without first cleaning test output directories",
617613
" --stackTraceLimit=<limit>": "Sets the maximum number of stack frames to display. Use 'full' to show all frames.",
618614
" --no-color": "Disables color",
619-
" --no-lint": "Disables lint",
620615
" --timeout=<ms>": "Overrides the default test timeout.",
621616
" --workers=<number>": "The number of parallel workers to use.",
622617
" --built": "Compile using the built version of the compiler.",

scripts/build/options.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const os = require("os");
44

55
/** @type {CommandLineOptions} */
66
module.exports = minimist(process.argv.slice(2), {
7-
boolean: ["dirty", "light", "colors", "lint", "lkg", "soft", "fix", "failed", "keepFailed", "force", "built"],
7+
boolean: ["dirty", "light", "colors", "lkg", "soft", "fix", "failed", "keepFailed", "force", "built"],
88
string: ["browser", "tests", "break", "host", "reporter", "stackTraceLimit", "timeout", "shards", "shardId"],
99
alias: {
1010
/* eslint-disable quote-props */
@@ -31,7 +31,6 @@ module.exports = minimist(process.argv.slice(2), {
3131
runners: process.env.runners || process.env.runner || process.env.ru,
3232
light: process.env.light === undefined || process.env.light !== "false",
3333
reporter: process.env.reporter || process.env.r,
34-
lint: process.env.lint || true,
3534
fix: process.env.fix || process.env.f,
3635
workers: process.env.workerCount || ((os.cpus().length - (process.env.CI ? 0 : 1)) || 1),
3736
failed: false,
@@ -51,7 +50,6 @@ if (module.exports.built) {
5150
* @property {boolean} dirty
5251
* @property {boolean} light
5352
* @property {boolean} colors
54-
* @property {boolean} lint
5553
* @property {boolean} lkg
5654
* @property {boolean} built
5755
* @property {boolean} soft

0 commit comments

Comments
 (0)