Enable completions in object binding patterns

[DanielRosenwasser]

Fixes #2676.

[mhegazy]

can we make this name a little bit better.. may be getObectLikeCompletionContainer for instance..

[DanielRosenwasser]

That's a...way way better name. 😄

[mhegazy]

thanks! Looks good..

Can you add a test for filtering when the property name is specified, eg. var { a: b, | } = .. where a should not show again in the completion list.

also a test with an array binding pattern with a nested object pattern let [{a}] = [{a: ""}];

[DanielRosenwasser]

Good idea on the array binding pattern, though I think I already wrote that other test you described a few times. Can you confirm whether that's the case @mhegazy?

[mhegazy]

i did not see any test with renamed properties.

[DanielRosenwasser]

@mhegazy ah, sorry, I misunderstood. Yes, I'll make one testing both of those as well as one testing parameters.

[DanielRosenwasser]

All good now?

[mhegazy]

👍

[mhegazy]

thanks!