Skip to content

Unclosed object binding patterns do not give correct completions #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRosenwasser opened this issue Jun 25, 2015 · 2 comments
Closed
Labels
Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it

Comments

@DanielRosenwasser
Copy link
Member

Now that #3615 is in, here's an annoying one for editors without brace completion:

interface Thing {
    abcdef: any;
}

interface I {
    property1: Thing;
    property2: string;
}
var foo: I;
var { property1: { /**/ } = foo;

Expected: abcdef is in the completion list.
Actual: property1 and property2 are in the completion list.

@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Jun 25, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Jul 2, 2015

This is a hard one to get right just because of the grammar.

@mhegazy mhegazy added the Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it label Jul 2, 2015
@mhegazy mhegazy closed this as completed Jul 2, 2015
@DanielRosenwasser DanielRosenwasser removed the Bug A bug in TypeScript label Jul 2, 2015
@DanielRosenwasser
Copy link
Member Author

Right - this shouldn't be a bug. I forgot that an initializer is valid on a nested binding pattern.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Projects
None yet
Development

No branches or pull requests

2 participants