Skip to content

Fix #33483 - Narrow unknown under inequality when assumed false #33488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jack-williams
Copy link
Collaborator

Fixes #33483

@RyanCavanaugh
Copy link
Member

LGTM but I'm curious

@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 18, 2019

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at f3e7b36. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 18, 2019

Heya @RyanCavanaugh, I've started to run the parallelized community code test suite on this PR at f3e7b36. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@RyanCavanaugh
Copy link
Member

User baseline diffs are noise

@RyanCavanaugh RyanCavanaugh merged commit 1c20aa0 into microsoft:master Sep 18, 2019
@jack-williams
Copy link
Collaborator Author

Thanks @RyanCavanaugh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict inequality operator (!==) type guard for unknown type
3 participants