Skip to content

Fix GH-32798: Allow == null to narrow unknown to null | undefined #45853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2021
Merged

Fix GH-32798: Allow == null to narrow unknown to null | undefined #45853

merged 4 commits into from
Sep 22, 2021

Conversation

hahmadia
Copy link
Contributor

Fixes #GH-32798

@hahmadia
Copy link
Contributor Author

@sandersn / @orta

Do you guys have time to review this PR. Much appreciated. Thank you!

gabritto
gabritto requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and your patience! :) I requested a minor change but otherwise this PR looks good to me.

@hahmadia hahmadia requested a review from gabritto September 21, 2021 01:02
gabritto
gabritto requested changes Sep 21, 2021
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one final comment, but I think after that we are ready to merge this. Thanks! ✨

@hahmadia hahmadia requested a review from gabritto September 22, 2021 13:04
@gabritto gabritto merged commit 110b059 into microsoft:main Sep 22, 2021
@hahmadia hahmadia deleted the GH-32798 branch September 22, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabritto gabritto gabritto approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@weswigham weswigham

Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hahmadia @gabritto @weswigham