Skip to content

Miscellaneous async code fix fixes #27188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2018
Merged

Miscellaneous async code fix fixes #27188

merged 2 commits into from
Sep 18, 2018

Conversation

uniqueiniquity
Copy link
Contributor

This is generally cleanup, so not wholly necessary for TS 3.1.

  • Remove unnecessary call to concat on a ReadonlyArray to convert to a mutable array
  • Clarify meaning of when an argName is set as undefined
  • Add test demonstrating when undefined is passed to catch
  • Narrow annotated type
  • Rename function to point out that a default value is produced

@uniqueiniquity uniqueiniquity requested review from amcasey and a user September 18, 2018 16:37
@ghost ghost mentioned this pull request Sep 18, 2018
Merged
amcasey
amcasey reviewed Sep 18, 2018
View reviewed changes
amcasey
amcasey approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@uniqueiniquity uniqueiniquity merged commit cd28af0 into microsoft:master Sep 18, 2018
@uniqueiniquity uniqueiniquity deleted the miscAsyncFixes branch September 18, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uniqueiniquity @amcasey