convertToAsyncFunction: Use ReadonlyArray / ReadonlyMap where possible #27190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
convertToAsyncFunction_readonlyarray
branch
from
bc4f4c6 to
c688f99
Compare
uniqueiniquity
approved these changes
Sep 18, 2018
|
Approved but please wait to merge until the last |
RyanCavanaugh
approved these changes
Sep 18, 2018
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while reviewing #27188 that we never actually need a
NodeArray, we can just useReadonlyArrays everywhere.All remaining
X[]arrays cause a compile error if changed toReadonlyArray.Also using
emptyArrayinstead of[]where possible to reduce allocations.