Skip to content

Do not read files greater than maxFileSize which is currently 4mb #26169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

sheetalkamat
Copy link
Member

Fixes #24762

@mjbvz

  • should we be sending you event for largeFile so you can show some kind of dialog?
  • Can you block sending open request to use if its a large file. Currently with this change vscode works well when i have import to "solc" module but if i click on solcjson.js file from node_modules/solc/ folder things will go bad because we arent reading contents from file but its passed by vscode.

@mjbvz
Copy link
Contributor

mjbvz commented Aug 3, 2018

Yes you send us an event, we can stop sending updates for these large files. Should we check the file size on our side before opening the file in the first place as well?

@sheetalkamat
Copy link
Member Author

@mjbvz Will create PR for event about large file in separate PR. Yes the large files shouldnt be sent to tsserver in open request at all.

@sheetalkamat sheetalkamat merged commit 77e29b7 into master Aug 3, 2018
@sheetalkamat sheetalkamat deleted the largeFile branch August 3, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants