Send event on referencing large file #26197
Conversation
|
If this were turning into telemetry (which I don't believe it is), the file size would be okay but the file path would not. |
|
@armanio123, should VS respond to this event? Do we want to show an info message or something? This seems similar to LS disabled. |
|
I think it might be a good idea to show an info message, just to make the user aware of what's happening on his project. Nevertheless, I don't think the feedback we have received relates to this scenario specifically or if we can get an action from the user by showing the message. |
|
Is this good to merge ? |
|
I have no objections, but Ryan only added me by accident. I know @sandersn is adding an event, so he might have thoughts. |
|
@RyanCavanaugh @sandersn Ok to merge ? |
|
I’m interested in this PR as an example of how to add a new flag, but I’ll take a look at the other parts now. |
| @@ -2436,6 +2436,27 @@ namespace ts.server.protocol { | |||
| openFiles: string[]; | |||
| } | |||
|
|
|||
| export type LargeFileReferencedEventName = "largeFileReferenced"; | |||
There was a problem hiding this comment.
Why is this code duplicated? I guess that’s one public and the other private, but why aren’t they shared?
There was a problem hiding this comment.
That's because we want to be able to build protocol.ts separately as a standalone to protocol.d.ts which editors consume.
Event when referencing large file as per #26169 (comment)