Skip to content

Add getCompilerOptions method to project #19222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2017
Merged

Add getCompilerOptions method to project #19222

merged 2 commits into from
Oct 16, 2017

Conversation

sheetalkamat
Copy link
Member

Fixes #19218

@vladima
Copy link
Contributor

vladima commented Oct 16, 2017

A comment why project has both getCompilationSettings and getCompilerOptions would be nice. Also sine getCompilerOptions is effectively an alias for getCompilationSettings it can be implemented as return this.getCompilationSettings()

@sheetalkamat sheetalkamat merged commit 5de6366 into master Oct 16, 2017
@sheetalkamat sheetalkamat deleted the projectCompilerOptions branch October 16, 2017 21:23
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @vladima @mhegazy