Skip to content

[loc][Query][TypeScript] Localizability of"0; "Import_Asterisk_as_0_from_1_95016" #19958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PDostalek opened this issue Nov 13, 2017 · 2 comments
Closed

[loc][Query][TypeScript] Localizability of"0; "Import_Asterisk_as_0_from_1_95016" #19958

PDostalek opened this issue Nov 13, 2017 · 2 comments
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue i18n (Ping PDostalek) Translation/Localization/Internationalization of messages in the compiler.
Milestone
TypeScript 2.7

Comments

@PDostalek
Copy link

PDostalek commented Nov 13, 2017 •
edited
Loading

Hi, we have a question from a translator. Could you help please?

Source:
Import * as '{0}' from "{1}".

File Name:
bin\Release\localize\ENU\diagnosticMessages.generated.json

Resource ID:
0; "Import_Asterisk_as_0_from_1_95016"

Query:
We are not sure if this string is localizable.
@mhegazy mhegazy added the i18n (Ping PDostalek) Translation/Localization/Internationalization of messages in the compiler. label Nov 13, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Nov 13, 2017

//cc @danyeh

@mhegazy mhegazy added the Bug A bug in TypeScript label Nov 14, 2017
@mhegazy mhegazy assigned mhegazy and unassigned csigs Nov 14, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Nov 14, 2017

Sorry missed the issue the first time. Indeed a localizability issue; I should have a fix for this shortly.

mhegazy added a commit that referenced this issue Nov 14, 2017
@mhegazy
Fix #19959 and #19958: Remove un-localizable messages
303b461
@mhegazy mhegazy mentioned this issue Nov 14, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 14, 2017
@mhegazy mhegazy added this to the TypeScript 2.7 milestone Nov 14, 2017
mhegazy added a commit that referenced this issue Nov 25, 2017
@mhegazy
Fix #19959 and #19958: Remove un-localizable messages (#20019)
6b3cfc7 
* Fix #19959 and #19958: Remove un-localizable messages

* Update message

* Update diagnostic messages
errendir added a commit to errendir/TypeScript that referenced this issue Nov 27, 2017
@errendir
Merge remote-tracking branch 'origin/master' into faster-interface-check
06c656a 
* origin/master:
  LEGO: check in for master to temporary branch.
  Fix microsoft#19959 and microsoft#19958: Remove un-localizable messages (microsoft#20019)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Port generated lib files (microsoft#20213)
  Update test baseline
  Offer global completions in all blocks
  Accept new baselines
  Add regression test
  Make sure 'async' isn't treated as a parameter modifier
mhegazy added a commit that referenced this issue Dec 2, 2017
@mhegazy
Remove periods from refactor/quickfix messages (#20237)
65af685 
* Fix #19959 and #19958: Remove un-localizable messages

* Update message

* Reorder error messages

* Fix #15399: remove periods at the end of messages

* Accept baselines for error code changes

* accept baselines for removed periods

* Update diagnostic messages
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue i18n (Ping PDostalek) Translation/Localization/Internationalization of messages in the compiler.
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
4 participants
@DanielRosenwasser @mhegazy @csigs @PDostalek