Remove periods from refactor/quickfix messages (#20237)

* Fix #19959 and #19958: Remove un-localizable messages

* Update message

* Reorder error messages

* Fix #15399: remove periods at the end of messages

* Accept baselines for error code changes

* accept baselines for removed periods

* Update diagnostic messages

Author: mhegazy

src/compiler/diagnosticMessages.json

@@ -2272,6 +2272,10 @@
         "category": "Error",
         "code": 2718
     },
+    "Type '{0}' is not assignable to type '{1}'. Two different types with this name exist, but they are unrelated.": {
+        "category": "Error",
+        "code": 2719
+    },
 
     "Import declaration '{0}' is using private name '{1}'.": {
         "category": "Error",
@@ -2719,6 +2723,11 @@
         "category": "Error",
         "code": 5067
     },
+    "Adding a tsconfig.json file will help organize projects that contain both TypeScript and JavaScript files. Learn more at https://aka.ms/tsconfig.": {
+        "category": "Error",
+        "code": 5068
+    },
+
     "Concatenate and emit output to single file.": {
         "category": "Message",
         "code": 6001
@@ -3710,7 +3719,7 @@
     },
     "JSX fragment is not supported when using --jsxFactory": {
         "category": "Error",
-        "code":17016
+        "code": 17016
     },
 
     "Circularity detected while resolving configuration: {0}": {
@@ -3730,104 +3739,95 @@
         "code": 18003
     },
 
-    "Add missing 'super()' call.": {
+    "Add missing 'super()' call": {
         "category": "Message",
         "code": 90001
     },
-    "Make 'super()' call the first statement in the constructor.": {
+    "Make 'super()' call the first statement in the constructor": {
         "category": "Message",
         "code": 90002
     },
-    "Change 'extends' to 'implements'.": {
+    "Change 'extends' to 'implements'": {
         "category": "Message",
         "code": 90003
     },
-    "Remove declaration for: '{0}'.": {
+    "Remove declaration for: '{0}'": {
         "category": "Message",
         "code": 90004
     },
-    "Implement interface '{0}'.": {
+    "Implement interface '{0}'": {
         "category": "Message",
         "code": 90006
     },
-    "Implement inherited abstract class.": {
+    "Implement inherited abstract class": {
         "category": "Message",
         "code": 90007
     },
-    "Add 'this.' to unresolved variable.": {
+    "Add 'this.' to unresolved variable": {
         "category": "Message",
         "code": 90008
     },
-    "Adding a tsconfig.json file will help organize projects that contain both TypeScript and JavaScript files. Learn more at https://aka.ms/tsconfig.": {
-        "category": "Error",
-        "code": 90009
-    },
-    "Type '{0}' is not assignable to type '{1}'. Two different types with this name exist, but they are unrelated.": {
-        "category": "Error",
-        "code": 90010
-    },
-    "Import '{0}' from module \"{1}\".": {
+    "Import '{0}' from module \"{1}\"": {
         "category": "Message",
         "code": 90013
     },
-    "Change '{0}' to '{1}'.": {
+    "Change '{0}' to '{1}'": {
         "category": "Message",
         "code": 90014
     },
-    "Add '{0}' to existing import declaration from \"{1}\".": {
+    "Add '{0}' to existing import declaration from \"{1}\"": {
         "category": "Message",
         "code": 90015
     },
-    "Declare property '{0}'.": {
+    "Declare property '{0}'": {
         "category": "Message",
         "code": 90016
     },
-    "Add index signature for property '{0}'.": {
+    "Add index signature for property '{0}'": {
         "category": "Message",
         "code": 90017
     },
-
-    "Disable checking for this file.": {
+    "Disable checking for this file": {
         "category": "Message",
         "code": 90018
     },
-    "Ignore this error message.": {
+    "Ignore this error message": {
         "category": "Message",
         "code": 90019
     },
-    "Initialize property '{0}' in the constructor.": {
+    "Initialize property '{0}' in the constructor": {
         "category": "Message",
         "code": 90020
     },
-    "Initialize static property '{0}'.": {
+    "Initialize static property '{0}'": {
         "category": "Message",
         "code": 90021
     },
-    "Change spelling to '{0}'.": {
+    "Change spelling to '{0}'": {
         "category": "Message",
         "code": 90022
     },
-    "Declare method '{0}'.": {
+    "Declare method '{0}'": {
         "category": "Message",
         "code": 90023
     },
-    "Declare static method '{0}'.": {
+    "Declare static method '{0}'": {
         "category": "Message",
         "code": 90024
     },
-    "Prefix '{0}' with an underscore.": {
+    "Prefix '{0}' with an underscore": {
         "category": "Message",
         "code": 90025
     },
-    "Rewrite as the indexed access type '{0}'.": {
+    "Rewrite as the indexed access type '{0}'": {
         "category": "Message",
         "code": 90026
     },
-    "Declare static property '{0}'.": {
+    "Declare static property '{0}'": {
         "category": "Message",
         "code": 90027
     },
-    "Call decorator expression.": {
+    "Call decorator expression": {
         "category": "Message",
         "code": 90028
     },
@@ -3871,11 +3871,11 @@
         "category": "Message",
         "code": 95010
     },
-    "Infer type of '{0}' from usage.": {
+    "Infer type of '{0}' from usage": {
         "category": "Message",
         "code": 95011
     },
-    "Infer parameter types from usage.": {
+    "Infer parameter types from usage": {
         "category": "Message",
         "code": 95012
     },

tests/baselines/reference/incompatibleAssignmentOfIdenticallyNamedTypes.errors.txt

@@ -1,4 +1,4 @@
-tests/cases/compiler/incompatibleAssignmentOfIdenticallyNamedTypes.ts(6,9): error TS90010: Type 'T' is not assignable to type 'T'. Two different types with this name exist, but they are unrelated.
+tests/cases/compiler/incompatibleAssignmentOfIdenticallyNamedTypes.ts(6,9): error TS2719: Type 'T' is not assignable to type 'T'. Two different types with this name exist, but they are unrelated.
 
 
 ==== tests/cases/compiler/incompatibleAssignmentOfIdenticallyNamedTypes.ts (1 errors) ====
@@ -9,7 +9,7 @@ tests/cases/compiler/incompatibleAssignmentOfIdenticallyNamedTypes.ts(6,9): erro
         fn() {
             this.x = a;
             ~~~~~~
-!!! error TS90010: Type 'T' is not assignable to type 'T'. Two different types with this name exist, but they are unrelated.
+!!! error TS2719: Type 'T' is not assignable to type 'T'. Two different types with this name exist, but they are unrelated.
         }
     }
 

tests/baselines/reference/moduleResolutionWithSymlinks_preserveSymlinks.errors.txt

@@ -1,4 +1,4 @@
-/app/app.ts(9,1): error TS90010: Type 'C' is not assignable to type 'C'. Two different types with this name exist, but they are unrelated.
+/app/app.ts(9,1): error TS2719: Type 'C' is not assignable to type 'C'. Two different types with this name exist, but they are unrelated.
   Types have separate declarations of a private property 'x'.
 
 
@@ -13,8 +13,8 @@
     // Should fail. We no longer resolve any symlinks.
     x = new C2();
     ~
-!!! error TS90010: Type 'C' is not assignable to type 'C'. Two different types with this name exist, but they are unrelated.
-!!! error TS90010:   Types have separate declarations of a private property 'x'.
+!!! error TS2719: Type 'C' is not assignable to type 'C'. Two different types with this name exist, but they are unrelated.
+!!! error TS2719:   Types have separate declarations of a private property 'x'.
 
 ==== /linked/index.d.ts (0 errors) ====
     export { real } from "real";

tests/cases/fourslash/codeFixAddForgottenDecoratorCall01.ts

@@ -9,6 +9,6 @@
 ////}
 
 verify.codeFix({
-    description: "Call decorator expression.",
+    description: "Call decorator expression",
     newRangeContent: `@foo()`
 });

tests/cases/fourslash/codeFixAddForgottenThis01.ts

@@ -8,7 +8,7 @@
 ////}
 
 verify.codeFix({
-    description: "Add 'this.' to unresolved variable.",
+    description: "Add 'this.' to unresolved variable",
     newRangeContent: `
         this.foo = 10;
     `

tests/cases/fourslash/codeFixAddForgottenThis02.ts

@@ -7,6 +7,6 @@
 ////}
 
 verify.codeFix({
-    description: "Add 'this.' to unresolved variable.",
+    description: "Add 'this.' to unresolved variable",
     newRangeContent: "this.foo = 10",
 });

tests/cases/fourslash/codeFixAddMissingMember.ts

@@ -7,7 +7,7 @@
 ////}
 
 verify.codeFix({
-    description: "Declare property 'foo'.",
+    description: "Declare property 'foo'",
     index: 0,
     // TODO: GH#18445
     newFileContent: `class C {

tests/cases/fourslash/codeFixAddMissingMember2.ts

@@ -7,7 +7,7 @@
 ////}
 
 verify.codeFix({
-    description: "Add index signature for property 'foo'.",
+    description: "Add index signature for property 'foo'",
     index: 1,
     // TODO: GH#18445
     newFileContent: `class C {

tests/cases/fourslash/codeFixAddMissingMember3.ts

@@ -7,7 +7,7 @@
 ////}
 
 verify.codeFix({
-    description: "Declare static property 'foo'.",
+    description: "Declare static property 'foo'",
     index: 0,
     // TODO: GH#18445
     newFileContent: `class C {

tests/cases/fourslash/codeFixAddMissingMember4.ts

@@ -13,7 +13,7 @@
 ////}
 
 verify.codeFix({
-    description: "Initialize property 'foo' in the constructor.",
+    description: "Initialize property 'foo' in the constructor",
     index: 0,
     // TODO: GH#18445
     newFileContent: `class C {

tests/cases/fourslash/codeFixAddMissingMember5.ts

@@ -11,7 +11,7 @@
 ////}
 
 verify.codeFix({
-    description: "Initialize static property 'foo'.",
+    description: "Initialize static property 'foo'",
     index: 0,
     // TODO: GH#18445
     newFileContent: `class C {

tests/cases/fourslash/codeFixAddMissingMember6.ts

@@ -11,7 +11,7 @@
 ////}
 
 verify.codeFix({
-    description: "Initialize property 'foo' in the constructor.",
+    description: "Initialize property 'foo' in the constructor",
     index: 0,
     // TODO: GH#18445
     newFileContent: `class C {

tests/cases/fourslash/codeFixAddMissingMember7.ts

@@ -9,7 +9,7 @@
 ////}
 
 verify.codeFix({
-    description: "Initialize static property 'foo'.",
+    description: "Initialize static property 'foo'",
     index: 2,
     // TODO: GH#18445
     newFileContent: `class C {

tests/cases/fourslash/codeFixChangeExtendsToImplements.ts

@@ -4,6 +4,6 @@
 //// [|/* */ class /* */ C /* */ extends /* */ I|]{}
 
 verify.codeFix({
-    description: "Change 'extends' to 'implements'.",
+    description: "Change 'extends' to 'implements'",
     newRangeContent: "/* */ class /* */ C /* */ implements /* */ I",
 });

tests/cases/fourslash/codeFixChangeExtendsToImplementsAbstractModifier.ts

@@ -6,7 +6,7 @@
 //// [|abstract class A extends I1 implements I2|] { }
 
 verify.codeFix({
-    description: "Change 'extends' to 'implements'.",
+    description: "Change 'extends' to 'implements'",
     // TODO: GH#18794
     newRangeContent: "abstract class A implements I1 , I2",
 });

tests/cases/fourslash/codeFixChangeExtendsToImplementsTypeParams.ts

@@ -4,6 +4,6 @@
 ////[|class C<T extends string , U> extends I<T>|]{}
 
 verify.codeFix({
-    description: "Change 'extends' to 'implements'.",
+    description: "Change 'extends' to 'implements'",
     newRangeContent: "class C<T extends string , U> implements I<T>",
 });

tests/cases/fourslash/codeFixChangeExtendsToImplementsWithDecorator.ts

@@ -11,7 +11,7 @@
 //// @sealed
 //// [|class A extends I1 implements I2 { }|]
 verify.codeFix({
-    description: "Change 'extends' to 'implements'.",
+    description: "Change 'extends' to 'implements'",
     // TODO: GH#18794
     newRangeContent: "class A implements I1 , I2 { }",
 });

tests/cases/fourslash/codeFixChangeJSDocSyntax1.ts

@@ -2,6 +2,6 @@
 //// var x: [|?|] = 12;
 
 verify.codeFix({
-    description: "Change '?' to 'any'.",
+    description: "Change '?' to 'any'",
     newRangeContent: "any",
 });

tests/cases/fourslash/codeFixChangeJSDocSyntax10.ts

@@ -4,7 +4,7 @@
 //// }
 
 verify.codeFix({
-    description: "Change 'number?' to 'number | null'.",
+    description: "Change 'number?' to 'number | null'",
     errorCode: 8020,
     index: 0,
     newRangeContent: "number | null",

tests/cases/fourslash/codeFixChangeJSDocSyntax11.ts

@@ -4,7 +4,7 @@
 //// }
 
 verify.codeFix({
-    description: "Change 'string?' to 'string | null | undefined'.",
+    description: "Change 'string?' to 'string | null | undefined'",
     errorCode: 8020,
     index: 1,
     newRangeContent: "string | null | undefined",

tests/cases/fourslash/codeFixChangeJSDocSyntax12.ts

@@ -5,7 +5,7 @@
 ////}
 
 verify.codeFix({
-    description: "Change '*' to 'any'.",
+    description: "Change '*' to 'any'",
     errorCode: 8020,
     index: 0,
     newRangeContent: "any",

tests/cases/fourslash/codeFixChangeJSDocSyntax13.ts

@@ -5,7 +5,7 @@
 ////}
 
 verify.codeFix({
-    description: "Change '*' to 'any'.",
+    description: "Change '*' to 'any'",
     errorCode: 8020,
     index: 0,
     newRangeContent: "any",

tests/cases/fourslash/codeFixChangeJSDocSyntax14.ts

@@ -3,7 +3,7 @@
 //// var x = 12 as [|number?|];
 
 verify.codeFix({
-    description: "Change 'number?' to 'number | null'.",
+    description: "Change 'number?' to 'number | null'",
     errorCode: 8020,
     index: 0,
     newRangeContent: "number | null",

tests/cases/fourslash/codeFixChangeJSDocSyntax15.ts

@@ -3,7 +3,7 @@
 
 // note: without --strict, number? --> number, not number | null
 verify.codeFix({
-    description: "Change 'function(number?): number' to '(arg0: number) => number'.",
+    description: "Change 'function(number?): number' to '(arg0: number) => number'",
     errorCode: 8020,
     index: 0,
     newRangeContent: "(arg0: number) => number",

tests/cases/fourslash/codeFixChangeJSDocSyntax16.ts

@@ -2,6 +2,6 @@
 //// var f: { [K in keyof number]: [|*|] };
 
 verify.codeFix({
-    description: "Change '*' to 'any'.",
+    description: "Change '*' to 'any'",
     newRangeContent: "any",
 });