Skip to content

Code Fix Description Should Not End With a Period #15399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue Apr 26, 2017 · 0 comments
Closed

Code Fix Description Should Not End With a Period #15399

mjbvz opened this issue Apr 26, 2017 · 0 comments
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 2.7

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 26, 2017

From microsoft/vscode#25407

TypeScript Version: 2.3.1

Request
Currently, the description for quick fixes ends with a period:

        "description": "Ignore this error message.",

The label for other code actions in VSCode do not end with a period. It looks a little odd in our UI:

screen shot 2017-04-26 at 1 32 30 pm

We can workaround this on our side if needed but I wanted to see if this current design was intentional
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Apr 26, 2017
@mjbvz mjbvz mentioned this issue Apr 26, 2017
Closed
@mhegazy mhegazy self-assigned this Apr 26, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label Apr 26, 2017
@mhegazy mhegazy added this to the TypeScript 2.4 milestone Apr 26, 2017
@mhegazy mhegazy modified the milestones: TypeScript 2.4, TypeScript 2.5 Jun 5, 2017
@mhegazy mhegazy modified the milestones: TypeScript 2.6, TypeScript 2.7 Oct 9, 2017
mhegazy added a commit that referenced this issue Nov 23, 2017
@mhegazy
Fix #15399: remove periods at the end of messages
7b3a403
@mhegazy mhegazy mentioned this issue Nov 23, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 25, 2017
mhegazy added a commit that referenced this issue Dec 2, 2017
@mhegazy
Remove periods from refactor/quickfix messages (#20237)
65af685 
* Fix #19959 and #19958: Remove un-localizable messages

* Update message

* Reorder error messages

* Fix #15399: remove periods at the end of messages

* Accept baselines for error code changes

* accept baselines for removed periods

* Update diagnostic messages
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
3 participants
@DanielRosenwasser @mhegazy @mjbvz