Skip to content

Remove stale JS-related code + Refactor + Improve comment.json support for added types #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
720 changes: 0 additions & 720 deletions JS.fsx

This file was deleted.

673 changes: 0 additions & 673 deletions Shared.fsx

This file was deleted.

2,157 changes: 1,410 additions & 747 deletions TS.fsx

Large diffs are not rendered by default.

21 changes: 21 additions & 0 deletions baselines/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12732,16 +12732,37 @@ interface Canvas2DContextAttributes {
}

interface URLSearchParams {
/**
* Appends a specified key/value pair as a new search parameter.
*/
append(name: string, value: string): void;
/**
* Deletes the given search parameter, and its associated value, from the list of all search parameters.
*/
delete(name: string): void;
/**
* Returns the first value associated to the given search parameter.
*/
get(name: string): string | null;
/**
* Returns all the values association with a given search parameter.
*/
getAll(name: string): string[];
/**
* Returns a Boolean indicating if such a search parameter exists.
*/
has(name: string): boolean;
/**
* Sets the value associated to a given search parameter to the given value. If there were several values, delete the others.
*/
set(name: string, value: string): void;
}

declare var URLSearchParams: {
prototype: URLSearchParams;
/**
* Constructor returning a URLSearchParams object.
*/
new (init?: string | URLSearchParams): URLSearchParams;
}

Expand Down
8 changes: 3 additions & 5 deletions build.fsx
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
#r "packages/FAKE/tools/FakeLib.dll"
#load "Shared.fsx"
#load "TS.fsx"

open Fake
open TS
open TS.Emit
open System
open System.IO

Target "Run" (fun _ ->
// For typescript only generate for Dom
TS.EmitDomWeb()
TS.EmitDomWorker()
TS.Emit.EmitDomWeb()
TS.Emit.EmitDomWorker()
)

let testFile file =
Expand Down
33 changes: 33 additions & 0 deletions inputfiles/comments.json
Original file line number Diff line number Diff line change
Expand Up @@ -3043,6 +3043,39 @@
],
"method": []
}
},
{
"name": "URLSearchParams",
"members": {
"method": [
{
"name": "append",
"comment": "/**\r\n * Appends a specified key/value pair as a new search parameter.\r\n */"
},
{
"name": "delete",
"comment": "/**\r\n * Deletes the given search parameter, and its associated value, from the list of all search parameters.\r\n */"
},
{
"name": "get",
"comment": "/**\r\n * Returns the first value associated to the given search parameter.\r\n */"
},
{
"name": "getAll",
"comment": "/**\r\n * Returns all the values association with a given search parameter.\r\n */"
},
{
"name": "has",
"comment": "/**\r\n * Returns a Boolean indicating if such a search parameter exists.\r\n */"
},
{
"name": "set",
"comment": "/**\r\n * Sets the value associated to a given search parameter to the given value. If there were several values, delete the others.\r\n */"
}
],
"property": [],
"constructor": "/**\r\n * Constructor returning a URLSearchParams object.\r\n */"
}
}
]
}
Loading