Skip to content

Remove stale JS-related code + Refactor + Improve comment.json support for added types #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2017

Conversation

zhengbli
Copy link
Contributor

@zhengbli zhengbli commented Jan 3, 2017

The JS-related things used to be useful for the JS language service in VS, but now it is not used anymore. This PR cleans up the code:

  • removed JS-related stuff
  • put all code in a single file TS.fsx
  • break things into smaller modules, making it more readable
  • code refactor in many places to improve speed

and also incorporated #168 for the comment.json support for added types.

@zhengbli
Copy link
Contributor Author

zhengbli commented Jan 3, 2017

@mhegazy as this is a quite big change, it can go stale pretty fast. Please take a look if you have time, thanks!

@zhengbli zhengbli merged commit ffa6906 into microsoft:master Jan 3, 2017
@zhengbli zhengbli deleted the refactor branch January 3, 2017 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants