This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Pass around MatrixClients instead of using MatrixClientPeg #10984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
t3chguy
requested review from
richvdh and
weeman1337
and removed request for
a team
richvdh
suggested changes
May 25, 2023
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
Split into sensible commits
sensible they may be, but 38, many of which are called "iterate", is too many for a plausible review
Member
Author
|
@richvdh fair, will split into 2/3 PRs |
Member
Author
|
Ah, half of the commits as from the previous PR in the chain and have 0 effect and need rebasing out, first commit of this PR really is at 131e0e8 |
t3chguy
force-pushed
the
t3chguy/types/foobar
branch
from
ef65d25 to
2d5d2eb
Compare
t3chguy
force-pushed
the
t3chguy/types/foobar
branch
from
2d5d2eb to
f5b6fe6
Compare
t3chguy
force-pushed
the
t3chguy/types/foobar
branch
from
f5b6fe6 to
f840124
Compare
richvdh
reviewed
May 31, 2023
src/DeviceListener.ts
Outdated
| // The set of device IDs we're currently displaying toasts for | ||
| private displayingToastsForDeviceIds = new Set<string>(); | ||
| private running = false; | ||
| private runningClient?: MatrixClient; |
Member
There was a problem hiding this comment.
tbh it feels a bit odd to conflate running and client: personally I would keep them separate, with a comment on client along the lines of "only defined when 'running' is true", even if, strictly speaking, running is then redundant.
richvdh
suggested changes
Jun 1, 2023
| private displayingToastsForDeviceIds = new Set<string>(); | ||
| private runningClient?: MatrixClient; | ||
| private running = false; | ||
| private client?: MatrixClient; |
Member
There was a problem hiding this comment.
comment please. When is it set, when is it undefined
Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #10905
Requires #11000
Split into sensible commits
This change is marked as an internal change (Task), so will not be included in the changelog.