Fix types & tests

Author: t3chguy

src/Lifecycle.ts

@@ -553,7 +553,7 @@ export async function hydrateSession(credentials: IMatrixClientCreds): Promise<M
         logger.warn("Clearing all data: Old session belongs to a different user/session");
     }
 
-    if (!credentials.pickleKey) {
+    if (!credentials.pickleKey && credentials.deviceId !== undefined) {
         logger.info("Lifecycle#hydrateSession: Pickle key not provided - trying to get one");
         credentials.pickleKey =
             (await PlatformPeg.get()?.getPickleKey(credentials.userId, credentials.deviceId)) ?? undefined;

src/ScalarMessaging.ts

@@ -876,7 +876,7 @@ const onMessage = function (event: MessageEvent<any>): void {
         // No integrations UI URL, ignore silently.
         return;
     }
-    let eventOriginUrl;
+    let eventOriginUrl: URL;
     try {
         eventOriginUrl = new URL(event.origin);
     } catch (e) {

src/rageshake/submit-rageshake.ts

@@ -189,7 +189,7 @@ async function collectBugReport(opts: IOpts = {}, gzipLogs = true): Promise<Form
 
             // compress
             if (gzipLogs) {
-                buf = pako.gzip(buf);
+                buf = pako!.gzip(buf);
             }
 
             body.append("compressed-log", new Blob([buf]), entry.id);

test/components/views/right_panel/UserInfo-test.tsx

@@ -500,7 +500,7 @@ describe("<DeviceItem />", () => {
         await userEvent.click(button);
 
         expect(mockVerifyDevice).toHaveBeenCalledTimes(1);
-        expect(mockVerifyDevice).toHaveBeenCalledWith(defaultUser, device);
+        expect(mockVerifyDevice).toHaveBeenCalledWith(mockClient, defaultUser, device);
     });
 
     it("with display name", async () => {