Skip to content

Conversation

kdorr
Copy link
Collaborator

@kdorr kdorr commented Aug 11, 2018

Converts line plots (all data types) successfully. Does not handle legend information.

This should only be merged after the "Reintroduce utils and related functions" PR is merged. The coverage check should pass after that.

Notes:

  • _data. _locate_channel_data() was changed to convert temporal data to matplotlib dates before returning the data rather than letting the data conversion happen elsewhere.
  • Slight behavior difference between Altair and mpl-altair: Altair won't render line plots where the column for opacity groups the data into a different shape than the column for color or stroke. mpl-altair renders this, but it's not meaningful at all.

kdorr and others added 10 commits August 8, 2018 12:32
Cleaner way to group the data for opacity, stroke, and color encodings.
In the process of working on this, it was necessary to have
_data._locate_channel_data() convert temporal data to matplotlib dates
rather than wait for another function to convert the dates.
@codecov
Copy link

codecov bot commented Aug 11, 2018

Codecov Report

Merging #20 into master will decrease coverage by 2.1%.
The diff coverage is 92.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage     100%   97.89%   -2.11%     
==========================================
  Files           8       10       +2     
  Lines         541      571      +30     
  Branches       58       71      +13     
==========================================
+ Hits          541      559      +18     
- Misses          0       10      +10     
- Partials        0        2       +2
Impacted Files Coverage Δ
mplaltair/_axis.py 100% <100%> (ø) ⬆️
mplaltair/tests/test_data.py 100% <100%> (ø) ⬆️
mplaltair/tests/test_convert.py 100% <100%> (ø) ⬆️
mplaltair/_convert.py 100% <100%> (ø) ⬆️
mplaltair/_marks.py 100% <100%> (ø)
mplaltair/tests/test_axis.py 100% <100%> (ø) ⬆️
mplaltair/_utils.py 46.15% <46.15%> (ø)
mplaltair/_data.py 93.67% <76.19%> (-6.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f7dbc...4c3ea42. Read the comment docs.

@kdorr
Copy link
Collaborator Author

kdorr commented Aug 15, 2018

Closing since PR #21 incorporates all of these changes.

@kdorr kdorr closed this Aug 15, 2018
@kdorr kdorr deleted the add-line branch August 15, 2018 16:22
@kdorr kdorr restored the add-line branch August 15, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant