Add Line and Refactor chart object #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaner way to group the data for opacity, stroke, and color encodings. In the process of working on this, it was necessary to have _data._locate_channel_data() convert temporal data to matplotlib dates rather than wait for another function to convert the dates.
Cleaner way to group the data for opacity, stroke, and color encodings. In the process of working on this, it was necessary to have _data._locate_channel_data() convert temporal data to matplotlib dates rather than wait for another function to convert the dates.
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 13 +3
Lines 585 589 +4
Branches 59 62 +3
=====================================
+ Hits 585 589 +4
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has all of the changes from #20, so this PR can be merged without merging #20.
Refactor: adding a chart object
Major refactor to create a chart object that parses the altair chart and stores relevant data and metadata conveniently for mpl-altair. Suggestions for better names for the object are welcome.
Add Line
Converts line plots (all data types) successfully. Does not handle legend information.
Notes: